Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add markers for each song part in exported Midi file #178

Open
jjazzboss opened this issue Feb 8, 2021 · 2 comments
Open

Add markers for each song part in exported Midi file #178

jjazzboss opened this issue Feb 8, 2021 · 2 comments
Assignees
@lezhdz98
Labels
enhancement New feature or request good first issue Good for newcomers low priority
Milestone
4.1.3

Comments

@jjazzboss
Copy link
Owner

Marker will be the song part name.
@jjazzboss jjazzboss added enhancement New feature or request good first issue Good for newcomers low priority labels Feb 8, 2021
@jjazzboss jjazzboss changed the title Add possibility to add markers for each song part in exported Midi file Add markers for each song part in exported Midi file Jul 5, 2021
@lezhdz98
Copy link

lezhdz98 commented Jan 2, 2025

I'm new doing contributions to open-source projects and I think this could be a good first task, can you assign this to me?

@jjazzboss jjazzboss added this to the 4.1.3 milestone Jan 3, 2025
@jjazzboss
Copy link
Owner Author

Yes thanks. You should create a pull request on the dev branch, the one I'm using for 4.1.3.

Some pointers:

https://github.com/jjazzboss/JJazzLab/blob/dev/core/RhythmMusicGeneration/src/main/java/org/jjazz/rhythmmusicgeneration/api/SongSequenceBuilder.java#L307

used by

https://github.com/jjazzboss/JJazzLab/blob/master/core/MusicControl/src/main/java/org/jjazz/musiccontrol/api/SongMidiExporter.java#L124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lezhdz98 lezhdz98

Labels
enhancement New feature or request good first issue Good for newcomers low priority
Projects
None yet
Milestone
4.1.3
Development

No branches or pull requests
2 participants
@jjazzboss @lezhdz98