Skip to content
This repository has been archived by the owner on Jul 16, 2019. It is now read-only.

Project requires watchdog but documentation does not mention it #33

Closed
petertiedemann opened this issue Mar 25, 2018 · 4 comments
Closed

Comments

@petertiedemann
Copy link

If you follow the steps in for example https://github.com/jjcollinge/traefik-on-service-fabric/blob/master/Docs/Deployments/VisualStudio.MD but do not use the "optional" watchdog, then the project will fail to build/package in the later steps. In order to proceed i had to delete all references to the watchdog in the various manifests and project files.

@jjcollinge
Copy link
Owner

Hi @petertiedemann - thanks for reporting this. I've updated the VS project to exclude any references to the watchdog unless explicitly added. Hope that helps clear up any confusion/issues. PR: feec7dc

@petertiedemann
Copy link
Author

@jjcollinge The reason i downloaded traefik manually was because i had problems with the Get-TraefikBinary script. When executed it asks for a url, even though the docs indicates that it will use a pre-defined one unless using the -url option. If no url is entered the result is this:

image

No watchdog or traefik file is downloaded as far as i can tell.

@jjcollinge
Copy link
Owner

You are correct, this needs updating - we changed the behaviour to require a URL as the builds should come from the official Traefik repository releases rather than our releases. I will make this clear in the documentation and update the script to reflect the expected behaviour.

@jjcollinge
Copy link
Owner

@petertiedemann I've updated the script to require a URL and updated the docs accordingly, thanks for flagging this. I'll close this for now - comment if it needs reopening.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants