internetarchive Item cant compute hash #540
Comments
cclauss
added a commit
to cclauss/internetarchive
that referenced
this issue
Dec 6, 2022
cclauss
added a commit
to cclauss/internetarchive
that referenced
this issue
Dec 6, 2022
cclauss
added a commit
to cclauss/internetarchive
that referenced
this issue
Dec 6, 2022
|
This was not fixed by #571. |
JustAnotherArchivist
added a commit
to JustAnotherArchivist/internetarchive
that referenced
this issue
Mar 21, 2024
Unless someone actively tries to break things by passing a crafted object, it should not generally be possible for there to be circular references. In addition, if someone were to do that, things would break in many other places, e.g. `MetadataPreparedRequest`, anyway. Guarding against a crash on hashing in that specific unusual scenario does not seem worthwhile and breaks when ujson is in use. Fixes jjjake#540
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
the hash function at https://github.com/jjjake/internetarchive/blob/master/internetarchive/item.py#L129 will fail if ujson is installed, as usjon.dumps doesnt have
check_circularparameterThe text was updated successfully, but these errors were encountered: