Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-repo: "playground-status" cannot check for some issues currently #42

Open
jku opened this issue Feb 25, 2023 · 0 comments
Open

git-repo: "playground-status" cannot check for some issues currently #42

jku opened this issue Feb 25, 2023 · 0 comments
Labels

Comments

@jku
Copy link
Owner

jku commented Feb 25, 2023

the design currently expects the GH action to call PlaygroundRepository.status(rolename) for each modified role:
this is useful but not sufficient.

Some cases this does not cover (there are probably more):

  • removed delegated roles
  • target files in targets/ changing without the metadata changing EDIT: DONE

I think maybe there needs to be a generic status check for the whole repository? If there is, then the role-specific one may be unneeded.

@jku jku added the git-repo label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant