Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-repo: Add git network support back to signer #61

Closed
jku opened this issue Mar 10, 2023 · 0 comments · Fixed by #63
Closed

git-repo: Add git network support back to signer #61

jku opened this issue Mar 10, 2023 · 0 comments · Fixed by #63
Labels

Comments

@jku
Copy link
Owner

jku commented Mar 10, 2023

The plan in #31 includes making both repository tools and signer integrate with git enough that

  • GH actions become simpler in "production"
  • the tools can be run in a local git repo for testing purposes
  • signer hopefully becomes easier to use

currently signer flow is

  1. get signing event branch (either create or pull from remote)
  2. run playground-sign
  3. git add & git commit
  4. git push to remote (that may or may not be same as the pull-remote)

I'd like this to be embedded in playground-sign:

  • "push-remote" and "pull-remote" need to be configured in .playground-sign.ini
  • signing-event (branch) name is either given as CLI arg (in this case fetch from remote, use a temp local branch)., Otherwise maybe we can make up the name?
    • it would be cool if playground-sign could figure out any currently open signing-events without a name...
  • git commit we can handle
  • git push to signing-event branch on push-remote -- this needs to be togglable with --push like in the repo tools
@jku jku linked a pull request Mar 13, 2023 that will close this issue
@jku jku added the git-repo label Mar 14, 2023
@jku jku closed this as completed in #63 Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant