Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closure bug in secret handler #94

Open
jku opened this issue Jun 7, 2023 · 0 comments
Open

closure bug in secret handler #94

jku opened this issue Jun 7, 2023 · 0 comments

Comments

@jku
Copy link
Owner

jku commented Jun 7, 2023

signers SignerRepository._sign() method has an inner method secret_handler that calls the actual handler set by the UI:

        def secret_handler(secret: str) -> str:
            return self._get_secret(secret, role)

This seems to have an issue where the value of role gets set when the inner function is first defined (when _sign() is first called)... meaning _get_secret() is always called with same value for role. This is not ideal

role is only used for output in the actual handler (_common.get_secret_input()): i'm removing the output for now but would like to re-add it once this is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant