getQuantity not working correctly for ingredients without a quantity

[Bash4195]

This example "Pinch salt and pepper ($0.05)" from BudgetBytes results in the ingredient being set to "pepper" and the quantity to " and".

Also could you please include a version number on the demo page? I'm not sure what version it's using but when entering this on that page, it seems to get confused when the parenthesis are included. But when I remove the parenthesis, it works perfectly. I've customized this package on my end to remove the parenthesis in the getQuantity function, but I don't get the same result as the demo, just the result as described previously. It looks like whatever version this demo uses has the solution to my problem but I'm not able to see what that is.

[jlucaspains]

Hello there! Seems like a bug related to how the word "and" is used to separate quantities (e.g. 1 and 1/2). I should be able to have a look this weekend.

As for the demo site, good question. I don't recall what version it is, but I like the idea to show the package version there somewhere.

[Bash4195]

Thanks so much for your reply! That sounds great!

I actually did eventually get it to work for that ingredient and it doesn't seem to conflict with anything else. It was setting the index to 6 which was causing it to miss "Pinch salt". I just added a check at the end of getQuantity that checks if the result is just the word "and", then reset the index and don't return anything.

if(units.ingredientQuantityAddMarker.includes(quantityText.trim())) {
    index = 0;
    quantityText = ""
  }

Hopefully that helps, I think you would know a lot better than me if this would cause other issues. Btw you're a hero for making and maintaining this repo!

[jlucaspains]

Hey @Bash4195. Thanks! I use this library a lot on my recipe book app. I'm glad other people can use it too.

I spent some quality time with the code but didn't get a great solution. I was able to fix the "and" short-circuiting the getQuantity result. However, the ($0.05) is now been identified as a quantity. Any other alternative I tried breaks a ton of unit tests. The screenshot below is from the unit test complaining about unexpected quantity.

You can see my tiny changes in the commit 15a43e1.

How much do you need that 0.05 at the end of the ingredient string? If we remove that part of the ingredient string the change above works as expected.

[jlucaspains]

I forgot to mention. The demo site uses one of the very first versions of the library that I made available. I never noticed how outdated it was. Currently, it uses version 1.1.0-beta.2. I will update it shortly.

[jlucaspains]

I got this working, but it was more expensive than I expected. PR #172 contains:

1. A new demo website that includes the package version, as requested. Rebuilding the site was easier than manually upgrading Svelte.
2. A new short-circuiting method to force the getQuantity method to stop consuming tokens once it finds a UOM. This requires a lookup in a dictionary that is slower than desired. I'm still considering whether this is the best way to resolve this problem and what the long-term impacts are.

[jlucaspains]

After testing for a while longer, the cost of the dictionary lookup wasn't as high as initially anticipated. I just closed the PR and will release a new package version and demo site with the changes. Please let me know if this fixes your problem.

[jlucaspains]

All done. Please try out the v1.3.2 of the sharp-recipe-parser package. You can also check the demo website with the new version (note the small version number of the bottom):

[Bash4195]

Hey there sorry for the late response, I wasn't feeling well this week.

Thanks so much for these changes! I've tested it on my end and it's definitely looking better. Your solution is a lot cleaner than mine too.

I did find one other scenario where it breaks down. With an ingredient like "Whole chicken, ($1.00)" it ends up thinking the quantity is 1 and doesn't get the ingredient after that. I was able to fix it by removing the parenthesis stuff before the call to getQuantity. Quick solution copied from elsewhere in the file:

const cleanTokens = [];
  let withinParenthesis = false;
  for (const item of tokens) {
    // remove anything within parenthesis
    withinParenthesis = withinParenthesis || item == "(";

    if (!withinParenthesis) {
      cleanTokens.push(item);
    }

    withinParenthesis = withinParenthesis && item != ")";
  }

That was the last major issue I found.

[jlucaspains]

Hey @Bash4195, I'm glad the previous solution worked for some scenarios. It didn't work for "Whole Chicken, ($1.00)" because there is no UOM to short-circuit the get number so it will go to the end and find the number within parenthesis. I don't know if there is a solution that won't break the other scenarios.

Do you mind creating a new issue for this problem? I will try to solve it but for what I checked tonight, no luck...