Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript Syntax highlighting by default #119

Open
bucktower opened this issue Nov 24, 2018 · 7 comments
Open

Typescript Syntax highlighting by default #119

bucktower opened this issue Nov 24, 2018 · 7 comments

Comments

@bucktower
Copy link

It would be very helpful to include Typescript syntax highlighting by default, given its increasing interest over the past couple years. Here's a ts.sublime-syntax that should work fine for the mean time for everyone else.

@jmacdonald
Copy link
Owner

Thanks for this! We're currently leaning on the syntect crate for built-in syntaxes; I think it's worth owning that responsibility in Amp so that we can include these without having to upstream them into that crate. 🙂

@jedahan
Copy link
Contributor

jedahan commented Nov 24, 2018

@bucktower mind adding that to the wiki as well? https://github.com/jmacdonald/amp/wiki

@al3rez
Copy link

al3rez commented Nov 24, 2018

@jmacdonald How about going like composition and not including specific syntax highlighting to keep amp fast and minimal?

@pbgc
Copy link

pbgc commented Nov 24, 2018

@jedahan I have some (like Coffeescript, Elixir, Dockerfile, Vue, etc) that I converted from .tmLanguage to .sublime-syntax but I don't know if I can share them on the wiki without attribution etc (I did not trace it and I don'r remember)

@jedahan
Copy link
Contributor

jedahan commented Nov 24, 2018

@pbgc I think if you make a repository under your name with your conversions, and write a readme that says "I don't remember where I got all of these. If its yours, let me know and I will add attribution" are you comfortable with that?

@jmacdonald
Copy link
Owner

@azbshiri I think that'd violate Amp's philosophy of "batteries included"; major languages/formats should work out of the box. 🙂

@melMass
Copy link

melMass commented Jan 18, 2019

JSX should be included too !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants