Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binaries Upgrade #22

Open
privateOmega opened this issue Dec 31, 2021 · 1 comment
Open

Binaries Upgrade #22

privateOmega opened this issue Dec 31, 2021 · 1 comment

Comments

@privateOmega
Copy link

Hey @jmhmd,

Thanks for this library.

I am planning to use this in a production setup and I was wondering if we could upgrade the binaries to latest version 3.6.6, as in do you anticipate any issues?

I noticed that you had stuck with 3.6.0 for mac and 3.6.2 for linux and windows which gives me the feeling that you must have done it for good reason. It would be great if you could post your reasoning here? I would happily raise a PR against this repo, for replacing the binaries and all that.

I have already forked your repo and exposed some other methods like pdf2dcm etc, but havent raised a PR since I hadn't worked on the matchers part, but hopefully will do it soon.

@jmhmd
Copy link
Owner

jmhmd commented Dec 31, 2021

Hi, glad you have found this useful.

The currently used versions were the latest prebuilt binaries I could find for each platform at the time I started this library. Since the library depends on parsing log output from dcmtk, it is potentially more risky to change versions as the log parsing might break if the log format changes at all between versions. Most likely a change in log format would not be considered a breaking change in dcmtk so might not be mentioned in release notes. There are some tests which will hopefully catch any major issues but not guaranteed. The versions used now have all the functionality I needed so I never bothered to upgrade.

Feel free to upgrade and test, hopefully the logging format is the same and everything will work as expected!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants