Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions - Flag Arguments #19

Open
jnguyen095 opened this issue Jul 5, 2017 · 0 comments
Open

Functions - Flag Arguments #19

jnguyen095 opened this issue Jul 5, 2017 · 0 comments

Comments

@jnguyen095
Copy link
Owner

  • Flag arguments are ugly. Passing a boolean into a function is a truly terrible practice. It
    immediately complicates the signature of the method, loudly proclaiming that this function
    does more than one thing. It does one thing if the flag is true and another if the flag is false!
  • Method call render(true) is just plain confusing to a poor reader
  • Method
render(boolean isSuite)

Should have split the function into two:

renderForSuite() 

and

renderForSingleTest().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant