Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KlipperLCD requires max_accel_to_decel to be defined #11

Closed
Joldiges opened this issue Apr 28, 2024 · 2 comments
Closed

KlipperLCD requires max_accel_to_decel to be defined #11

Joldiges opened this issue Apr 28, 2024 · 2 comments

Comments

@Joldiges
Copy link

Joldiges commented Apr 28, 2024

AFAIK, max_accel_to_decel isn't enabled in configurations that don't have input-shaper (yet) enabled.
KlipperLCD is requiring it to be defined. Perhaps have this script include use the dictionary default param to return -1 or N/A. (this is what I did for my own instance)

@jofland
Copy link

jofland commented Apr 29, 2024

AFAIK, max_accel_to_decel isn't enabled in configurations that don't have input-shaper (yet) enabled. KlipperLCD is requiring it to be defined. Perhaps have this script include use the dictionary default param to return -1 or N/A. (this is what I did for my own instance)

Could you please post the code snippets of your workaround?

@Joldiges
Copy link
Author

Joldiges commented May 1, 2024

I'll raise a PR #12 is rasied

max_accel_to_decel has officially been deprecated

20240313: The max_accel_to_decel parameter in the [printer] config section has been deprecated. The ACCEL_TO_DECEL parameter of the SET_VELOCITY_LIMIT command has been deprecated. The printer.toolhead.max_accel_to_decel status has been removed. Use the minimum_cruise_ratio parameter instead. The deprecated features will be removed in the near future, and using them in the interim may result in subtly different behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants