Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: investigate ctx.willReadFrequently, offscreenCanvas, worker #21

Open
joedf opened this issue Mar 6, 2023 · 2 comments
Open

Performance: investigate ctx.willReadFrequently, offscreenCanvas, worker #21

joedf opened this issue Mar 6, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@joedf
Copy link
Owner

joedf commented Mar 6, 2023 •
edited
Loading

just add ctx.willReadFrequently = true; in ComputeProbeValue_gs() seem to produce a minor speed improvement... but maybe it's now CPU-bound? maybe a context should be passed instead of an image/canvas if possible?

https://caniuse.com/?search=willReadFrequently
@joedf joedf added the enhancement New feature or request label Mar 6, 2023
@joedf
Copy link
Owner Author

joedf commented Mar 10, 2023 •
edited
Loading

@joedf joedf changed the title Performance: investigate ctx.willReadFrequently Performance: investigate ctx.willReadFrequently & offscreenCanvas Mar 10, 2023
@joedf joedf changed the title Performance: investigate ctx.willReadFrequently & offscreenCanvas Performance: investigate ctx.willReadFrequently, offscreenCanvas, worker Mar 11, 2023
joedf added a commit that referenced this issue Mar 11, 2023
@joedf
#21 - use offscreen canvas for ComputeProbeValue_gs()
7737a73 
Huge performance boost in firefox, but no change in edge/chrome. Now, it's even faster in firefox, edge/chrome used to be the faster one...
joedf added a commit that referenced this issue May 11, 2023
@joedf
performance/optimize spot layout draw
88c368f 
Related: #21
joedf added a commit that referenced this issue May 17, 2023
@joedf
datgui for Options UI, various improvements and bug fixes (#33)
5905558 
* dat.gui bindings, fix export btn, vSEM pause

* default advancedMode off

* display pixel count on result image

* add pxSize, stage coords, mag opts

added pixelSize opt, virtual coords display in "real" units, mag display

* minor clean up

* rename mag to digitalMag

* dat.gui opacity 90%

* add lazy FOV width display

* more resampled subregion to advancedMode

* draggable dat.gui, some clean up

* dat.gui drag/z-index fixes

* performance/optimize spot layout draw

Related: #21

* bugfix: import btn was broken

* bugfix: spot layout was drawing image multiple times

* move result subregion back out of advanced mode

* dat.gui options folders

* tweak UI issues

* Update package-lock.json

* Update package-lock.json

* Resampled row-by-row draw, ...

Some clean up, more opts for computeResampledSlow(),

* minor eslint clean up

* display result pixelSize, add formatUnitNm()

* fix advanceMode not respected on img change

* fix advMode, less duplicate code/cleaner

* more efficient ProbeLayoutSampling preview ...

fix resampling auto-update from G_AUTO_PREVIEW_LIMIT, some clean up

* fix possible update bug in drawProbeLayout()

minor clean up

* eslint issue G_AUTO_PREVIEW_LIMIT

* performance for sub-resampled, add pause for it

* better TIFF support using UTIF.js

* bugfix: Utils.ensureInfoBox() for stale handlers

fix the set spot width prompt being broken after the input image was changed

* simplify Utils.computeCellSize()

* add vSEM mode warning sub-resampled view

* some clean up

* some clean up

* display pxSize for result subregion, some clean up
@joedf
Copy link
Owner Author

joedf commented Dec 19, 2024 •
edited
Loading

Note to self: tested again today, the offscreenCanvas commit is the largest performance boost; a 137x zoom image went from ~50ms to ~15ms per row in the SEM live view.

  1. Commit where offscreenCanvas is being used: 7737a73
  2. Commit just before it: 8ddaf9f
  3. newest commit presently: 6577079

1 & 3 performed the same, 2 was slowed and eventually crashes the tab when switching away and back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joedf