Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate stratigraphs #1

Closed
tsdye opened this issue Dec 19, 2018 · 3 comments
Closed

Validate stratigraphs #1

tsdye opened this issue Dec 19, 2018 · 3 comments

Comments

@tsdye
Copy link

tsdye commented Dec 19, 2018

I don't know the R graph packages well, but you'll want to use one that is able to check for cycles. I browsed ggraph and didn't see anything there, but igraph will run this check. I believe that is what @nevrome was getting at in the thread with @zachbatist when he mentioned the logic check.

Also, if you decide to push forward with this, please consider the data structures set out by Dye and Buck (2015) and used in hm. The idea there was to have hm read csv files generated by SQL queries.

@joeroe
Copy link
Owner

joeroe commented Dec 19, 2018

Thanks @tsdye. I'm using tidygraph and ggraph as convenient wrappers, but the workhorse behind both is igraph, so yes hopefully verifying the topology will be easy.

I'll certainly look (again) at the way hm structures the data. If I recall correctly it's very compatible with the "tidy" approach used in modern R, so that should work well. The idea is not to compete with packages like hm or ArkMatrix, just to provide a version for those of us that are stuck in R ways!

@tsdye
Copy link
Author

tsdye commented Dec 19, 2018

Ah, good to know about the tidyverse wrappers. Thanks.

Competition is good! In any event, you can be fairly certain your good ideas in stratigraphr will make their way into hm some day :)

@joeroe
Copy link
Owner

joeroe commented Dec 29, 2018

Basic validation was indeed easy. Input formats and data structures perhaps requires more thought: #2

@joeroe joeroe closed this as completed Dec 29, 2018
@joeroe joeroe changed the title It is easy :) Validate stratigraphs Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants