Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method files.upload is no longer supported by Slack for new Applications #168

Open
george-viaud opened this issue May 22, 2024 · 8 comments

Comments

@george-viaud
Copy link

It seems that as of the 16th of May, 2024 the files.upload method is no longer authorized for new bots.

https://api.slack.com/changelog/2024-04-a-better-way-to-upload-files-is-here-to-stay

The current client api definitions don't appear to have a filesGetUploadURLExternal() or filesCompleteUploadExternal() method (or I'm calling them incorrectly)

@travisamiller
Copy link

According to Slack, support for files.Upload ends March 11, 2025.

Per @george-viaud question, should filesGetUploadURLExternal() and filesCompleteUploadExternal() appear in the SDK?

@damienalexandre
Copy link
Member

Would someone be able to submit a pull request about this?

Some documentation:

@conspiracyops
Copy link

up

@maybe-Baylie
Copy link

I can pick this up tomorrow morning

@maybe-Baylie
Copy link

@damienalexandre When I regenerated the client it converted the entire normalizer directory (448 files) to formal ::class from strings. Are you okay with me including that in the PR?

On a side note,
It looks like Slack is no longer updating the spec that is hosted on Slack's github used in UpdateSpecificationCommand.php. Given this, will all updates have be hand coded going forward in the patched schema?

@maybe-Baylie
Copy link

#176

@maybe-Baylie
Copy link

Based on slacks new file upload flow

  1. Get upload url from call to files.getUploadURLExternal
  2. Send post request to returned url
  3. finalize upload with call to files.completeUploadExternal

Should we add an additional post method to the spec to facilitate the sending in step 2 @damienalexandre ?

@grena
Copy link

grena commented Feb 24, 2025

Should we add an additional post method to the spec to facilitate the sending in step 2 @damienalexandre ?

For information in their official Slack node sdk, they implemented a dedicated filesUploadV2 method that seems to follow this new flow, so I think it could be a good idea to also implement one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants