Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default auth description #9

Open
chunningham opened this issue Apr 29, 2019 · 2 comments
Open

default auth description #9

chunningham opened this issue Apr 29, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@chunningham
Copy link
Contributor

The default description for an auth request is the default description for payment, "Authorize the transaction". Should be "Authentication Required" or something.

To Replicate:
use node cli.js request auth "someURL" and decode the input to see the description

@chunningham chunningham added the bug Something isn't working label Apr 29, 2019
@saifahn
Copy link

saifahn commented Apr 30, 2019

This was actually the default description we decided on, but thinking about it now it does seem kind of weird. "Authorize the interaction" might work? It is in this form because it is the description that fits between "Would you like to [INSERT PHRASE] with your SmartWallet?"

@chunningham
Copy link
Contributor Author

ah, if we've already discussed it then we can close this. It just seems odd to mention a transaction when its not dealing with payment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants