Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting of the cell_sorting example #2

Closed
Armavica opened this issue Jan 27, 2025 · 5 comments
Closed

Plotting of the cell_sorting example #2

Armavica opened this issue Jan 27, 2025 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Armavica
Copy link
Contributor

Armavica commented Jan 27, 2025

Hi, as part of the review of your software/article that I am doing for JOSS (openjournals/joss-reviews#7723), I tried to run the first example myself.

I was eventually able to generate the video, but I had to adapt the file cellular_raza-examples/cell_sorting/generate_movie.sh that refers to a file plot.py which I believe should actually be src/plot.py?

@jonaspleyer jonaspleyer added the documentation Improvements or additions to documentation label Jan 27, 2025
@jonaspleyer
Copy link
Owner

Thanks for reviewing cellular_raza. I hope that you saw the link to the hompage https://cellular-raza.com/ at which I give more details and explanations with in-depth guides on how to construct a first simulation from scratch.

You are referring to the file cellular_raza-examples/cell_sorting/generate_movie.sh which points to plot.py which itself was moved to src/plot.py. I will correct the path to src/plot.py and add an additional README.md to clear things up.

@jonaspleyer
Copy link
Owner

jonaspleyer commented Jan 27, 2025

Update: See commits: 0b55a91 2cdf63d in which I addressed the points from above.

Please let me know if you want to be listed as co-author for the changes made. I will be happy to include you but also fine with either choice.

Edit: Use new commit hashes.

@Armavica
Copy link
Contributor Author

Sounds good! Yes, I was indeed referring to this file. I did see the showcase on the website, but as this example is also provided in the repository that's how I tried to run it: it is what felt the most convenient to me on the moment. Either way is fine as long as it works!
Please don't include me on the changes, I am just reporting issues :)

@jonaspleyer
Copy link
Owner

Please don't include me on the changes, I am just reporting issues :)

Noted and removed from previous commits. 👍

@jonaspleyer
Copy link
Owner

Closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Development

No branches or pull requests

2 participants