Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null or "" for root doesn't work anymore #143

Closed
shirotech opened this issue Jul 9, 2018 · 3 comments
Closed

Null or "" for root doesn't work anymore #143

shirotech opened this issue Jul 9, 2018 · 3 comments
Labels
bug Something isn't working

Comments

@shirotech
Copy link

When I patch an element with either null or "", I was expecting to be empty, but it's throwing errors. This was not the case for previous versions. Let me know if need a codepen. Cheers.
@jorgebucaran
Copy link
Owner

@Van-Nguyen Yeah, I know. What is your use case?

@shirotech
Copy link
Author

One major use case is for Modals and popups. Since we don't have unmount.

@jorgebucaran
Copy link
Owner

Please join the convo in #136.

@jorgebucaran jorgebucaran added the bug Something isn't working label Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jorgebucaran @shirotech