login container for API integration #153
Conversation
onkar-josh
force-pushed
the
feature/react/140/container-for-login-api-integration
branch
from
9072159 to
14f8114
Compare
onkar-josh
assigned onkar-josh and mayuriardad and unassigned mayuriardad and onkar-josh
| export function* userLogin(action) { | ||
| try { | ||
| const response = yield call(PostJson, { | ||
| path: "/oauth/google", |
There was a problem hiding this comment.
@onkar-josh Where are maintaining the Google app credentials required for Google OAuth? i.e client IDs, secret keys?
There was a problem hiding this comment.
@mayuriardad we will maintain those credentials in component where google button will be located and pass them as a environment variables.
There was a problem hiding this comment.
@onkar-josh Similar to how u have used ENV variables on node side, do not use ENV variables directly in code. Instead, assign all ENV variables to constants (we already have a constants file) and use those constants in ur code.
|
|
||
| if (loginAuthorization.error.message === "unauthorized user") { | ||
| return <UnauthorisedErrorComponent />; | ||
| } else if (loginAuthorization.error.error === "popup_closed_by_user") { |
There was a problem hiding this comment.
why different keys? sometimes error.error and sometimes error.message?
There was a problem hiding this comment.
error.error is the error send by google and error.message is the error which will come from api
There was a problem hiding this comment.
I checked the wiki doc: https://github.com/joshsoftware/peerly/wiki/API-documentation#error-response-1. Couldn't find any reference for error.error.
@onkar-josh can u please help me understand from where did u get this error structure?
There was a problem hiding this comment.
actually this error is not part of API. this error occurs when we close pop-up window of google.
onkar-josh
force-pushed
the
feature/react/140/container-for-login-api-integration
branch
from
99de49d to
47210fe
Compare
onkar-josh
removed
the
Changes Requested
add styling for login form component #149