Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support zsh (and possibly fish) #37

Closed
joshuanianji opened this issue Jan 3, 2024 · 0 comments · Fixed by #38
Closed

Support zsh (and possibly fish) #37

joshuanianji opened this issue Jan 3, 2024 · 0 comments · Fixed by #38

Comments

@joshuanianji
Copy link
Owner

joshuanianji commented Jan 3, 2024

Now that I've been using dotfiles in my devcontainers (with zsh and omz) I'm realizing how my poorly my features support different scenarios.

  1. pnpm mount fails with pnpm not found if default shell is zsh (might be related to Avoid unexpected shell expansion devcontainers/features#645)
  2. All features that use volume mounts do not add stuff to .zshrc. An example feature that supports this is stuartleeks/shell-history

I don't use fish shell so I'm in no rush to support it, but it'll be nice to support it anyway

@joshuanianji joshuanianji linked a pull request Jan 8, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant