Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRIX bug #45

Open
coderxiaok opened this issue May 24, 2017 · 0 comments
Open

TRIX bug #45

coderxiaok opened this issue May 24, 2017 · 0 comments

Comments

@coderxiaok
Copy link

coderxiaok commented May 24, 2017

Hi Joshua, I found a bug in the TRIX function. If the "maType" is not a list variable, the "nSig" parameter will not be used when calculating the signal value from the TRIX value. Instead, the "n" parameter will be used as the "nSig" parameter.

Some of the code as bellow:
if (is.list(maType)) { signal <- do.call(maType[[4]][[1]], c(list(TRIX), maType[[4]][-1])) } else { signal <- do.call(maType, c(list(TRIX), list(n = n, ...))) }

The correct code might be:
if (is.list(maType)) { signal <- do.call(maType[[4]][[1]], c(list(TRIX), maType[[4]][-1])) } else { signal <- do.call(maType, c(list(TRIX), list(n = nSig, ...))) }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant