Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to open workouts without a name #388

Closed
martn263 opened this issue Jan 8, 2025 · 4 comments · Fixed by #389
Closed

Unable to open workouts without a name #388

martn263 opened this issue Jan 8, 2025 · 4 comments · Fixed by #389

Comments

@martn263
Copy link

martn263 commented Jan 8, 2025

In the 'Workouts' list, workouts cannot be opened if they lack a name. These workouts are imported as *.gpx files using the auto-import directory feature and are originally exported by HealthFit (iOS).

Suggested solutions:

  1. Implement a placeholder name for workouts that have an empty name field in the database.
  2. Add a clickable link to the workout type icon or the date column to allow access to the workout details even when the name is missing.
jovandeginste added a commit that referenced this issue Jan 8, 2025
@jovandeginste
Refactor(views): Improve workout and route segment name display
577ef91 
The name display of workouts and route segments has been improved to handle long
names and empty names more gracefully. A new helper function `Name` was added to
handle this consistently across the application.

Fixes #388

Signed-off-by: Jo Vandeginste <[email protected]>
@jovandeginste jovandeginste mentioned this issue Jan 8, 2025
Merged
@jovandeginste
Copy link
Owner

There should not be workouts with empty names (there must be a bug somewhere else), but in case it happens, there will now be a placeholder.

@jovandeginste
Copy link
Owner

Would you be able to provide me such a gpx file with limited personal information?

@martn263
Copy link
Author

martn263 commented Jan 8, 2025

Thanks for the quick fix. The placeholder '(no name)' works as expected for workouts without a name. I've sent the GPX sample to your email.

@jovandeginste
Copy link
Owner

Now fixed in #390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor(views): Improve workout and route segment name display jovandeginste/workout-tracker
2 participants
@jovandeginste @martn263