Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Split Layout From VBA should be grayed out if Sanitize is off #554

Open
hecon5 opened this issue Oct 23, 2024 · 2 comments
Open

Bug: Split Layout From VBA should be grayed out if Sanitize is off #554

hecon5 opened this issue Oct 23, 2024 · 2 comments

Comments

@hecon5
Copy link
Contributor

hecon5 commented Oct 23, 2024

If Sanitize Level is set to None (Off), we should gray out Split layout from VBA, because it doesn't do anything.

We should also update the Wiki with this info.

@joyfullservice
Copy link
Owner

I am starting to wonder if we should even allow none for the sanitize level... It's really not practically usable for the purposes of this add-in, and the resulting export may not even be viable for build, as seen in #552.

In concept it's nice to be able to export natively without any modification to the file, but it seems like new users tend to get led astray on the purpose of this option. I am just questioning whether it is worth the effort of building compatibility for an option that isn't really useful in the intended purpose of the add-in. If Minimal, Standard and Extended are the only options, people will pick one and go on their way.

If someone wants to test the manual export and import of an object, they can do it from the immediate window with a single line of code.

SaveAsText acForm, "frmMain", "frmMain.bas"
LoadFromText acForm, "frmMain", "frmMain.bas"

@hecon5
Copy link
Contributor Author

hecon5 commented Oct 23, 2024

I am starting to wonder if we should even allow none for the sanitize level... It's really not practically usable for the purposes of this add-in, and the resulting export may not even be viable for build, as seen in #552.

Ya know...I think you're right.

I was actually playing with Sanitization regarding #551 also, and with it set to off, I cannot build, either.

I do think we need to allow the Color Sanitize to be off (it doesn't affect buildability as far as I can tell).

Proposed fix options

  1. Get rid of eslNone. I don't like this, as we may need it for colors.
  2. Filter out None (Off) option for the Sanitize Level
  3. Keep None (Off) as a visible option. When user selects it, popup, and tell user that's not an option and set to Minimal. Popup will tell user to use SaveAsText acForm and prints this to the immediate window (so they have a demonstration), with the save location set to the Development location + RAW_Export as the subfolder. Eg: if C:\dev\Database.accdb.src is the dev location, the folder will be C:\dev\Database.accdb.src\Raw_Export.
  4. Keep None (Off) as a visible option. When user selects it silently convert to Minimal.
  5. Keep None (Off) as a visible option. When user selects it, popup, ask user if they want to do a ONE TIME export w/o sanitization. This would immediately trigger an unsanitized export, and then leave the sanitize option as-is (defaults to Standard).

For the options upgrade path, I'd propose we upgrade eslNone to eslMinimal for the fewest surprises, perhaps even giving them a popup message box we suggest changing to eslStandard, and upgrading to eslStandard if they say yes.

Personally, I think option 5 is the most UX friendly. It lets low-code devs still get a "raw" export, and we nudge users to use eslStandard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants