Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PlaceholderAPI processing from commands #113

Open
jpenilla opened this issue Jul 6, 2022 · 0 comments
Open

Remove PlaceholderAPI processing from commands #113

jpenilla opened this issue Jul 6, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@jpenilla
Copy link
Owner

jpenilla commented Jul 6, 2022

Running commands through PlaceholderAPI can cause some edge case issues, see #112.

A solution to this could be removing PAPI processing for command strings and adding our own <player_name> and etc replacements for commands. This would allow the command being executed to handle PAPI if it wants to, or not. This wouldn't impact executing AP commands as they will process the placeholders as part of command execution.

This needs consideration to ensure we don't lose any functionality with this change. Also config upgrading logic will be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant