Skip to content
This repository was archived by the owner on Nov 7, 2019. It is now read-only.

Breaking Bug #49

Open
audiolion opened this issue Jul 19, 2017 · 1 comment
Open

Breaking Bug #49

audiolion opened this issue Jul 19, 2017 · 1 comment

Comments

@audiolion
Copy link

audiolion commented Jul 19, 2017

The patched css provided with this library breaks any modals that were not created through this library/react. For instance if a page contained just the html markup for a modal it breaks due to the following code:

.modal {
  display: block
}

These other modals now will render on top of everything on the page but still be invisible and non-interactive so from the user perspective the entire page becomes unresponsive, but really its just that the modal is masking everything on the page and the user cannot dismiss it or see that it is there.

I am not sure why it was added or what its purpose is, it was introduces in this commit which has a huge diff and whose commit message is "boom".

@thucnd
Copy link

thucnd commented Aug 25, 2017

simple way
You change to

div.modal.fade.in {
  display:block
}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants