Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix query param deprecation and bump streamlit to 1.30 #41

Closed
wants to merge 5 commits into from
Closed

fix query param deprecation and bump streamlit to 1.30 #41

wants to merge 5 commits into from

Conversation

444B
Copy link

@444B 444B commented Jan 12, 2024

Changes:

  1. Update main.py
    changed st.experimental_get_query_params to st.query_params
  1. Update Pipfile.lock
    bumping streamlit version from 1.13 to 1.30
  • requires testing for breaking changes

This should resolve #39

444B added 4 commits January 12, 2024 13:55
changed st.experimental_get_query_params to st.query_params
- reason (st.experimental_get_query_params deprecation)
https://docs.streamlit.io/library/api-reference/utilities/st.experimental_get_query_params
bumping streamlit version from 1.13 to 1.30
- requires testing for breaking changes
@444B
Copy link
Author

444B commented Jan 12, 2024

@mt-krainski visibility

@444B
Copy link
Author

444B commented Jan 22, 2024

@jrieke Are you available to take a look at this?
Please let us know if you are still actively maintaining this repo

@RazHadas
Copy link

Hi,
still not working for me. can you please more detail how to do it.
I use streamlit 1.30

@444B
Copy link
Author

444B commented Jan 23, 2024

@RazHadas
I am hoping to get the change made in streamlit-analytics with this pull request

In the meantime, you can maybe specify in your requirements.txt or pipfile or whichever dependency file you have to use a streamlit version that is prior to 1.30

@RazHadas
Copy link

Thanks for the quick response. I will check it.

@444B
Copy link
Author

444B commented Jan 25, 2024

I messaged the author on Linkedin but no response so it would seem this project is not maintained...
Perhaps we will need to fork this repo and fix this issues independently but then the issue becomes around publishing the packages via pypi and pip, which I have less experience with but certainly can learn
Ill create an new issue stating this if we take this path
Tag me if you are interested in contributing
#TODO look into the licence of this repo and understand the implications of forking

@jrieke visibility

@RazHadas
Copy link

The analytics is streamlit is really problematic. I already try for few days to get unique page views.

@444B
Copy link
Author

444B commented Jan 25, 2024

The analytics is streamlit is really problematic. I already try for few days to get unique page views.

Hi @RazHadas
I have reached out to @jrieke on linkedin, here on Github and also just sent them an email to ask about how we can contribute and if the repo is being maintained or not
Without a response from them soon, I will be forking the project and fixing these issue in a new repo
Ill update you if that occurs and place it into this repo as a new issue

@RazHadas
Copy link

Sounds good. I just find script that get ip and screen resolution from user in streamlit, I want to improve the analytics.
By the way, did you manage to work with Google analytics 4 in streamlit?

@444B
Copy link
Author

444B commented Jan 25, 2024

Note: I am pushing this to my own fork but it seems be to included in this PR
Not sure why that would be tbh

@RazHadas The GA4 integration is something I want to work on in the future

@444B 444B changed the title fix query param depracation and bump streamlit to 1.30 fix query param deprecation and bump streamlit to 1.30 Jan 25, 2024
@444B 444B closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix usage of deprecated experimental_get_query_params
2 participants