Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties Case Class inside Feature instead of JSObject #18

Open
zmays opened this issue Feb 8, 2017 · 1 comment
Open

Properties Case Class inside Feature instead of JSObject #18

zmays opened this issue Feb 8, 2017 · 1 comment

Comments

@zmays
Copy link

zmays commented Feb 8, 2017

Thanks for the lib, has come in quite handy.

One thing I came across when using the lib is the desire to describe a case class for the particular properties I deal with.

relevant snippet here:
case class Feature[C](geometry: Geometry[C], **properties: Option[JsObject] = None**, id: Option[JsValue] = None, bbox: Option[(C, C)] = None) extends GeoJson[C]

With the way it is now, working with properties if you need to is a little difficult, and one has less control on the writes - if properties was a generic passed in I could describe the read and write functionality needed.

I'm happy to contribute if you think this makes sense assuming you don't already have ideas on how to handle this that I am missing.

@guizmaii
Copy link

Hi,

I'm working on this in the following PR : #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants