-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't edit the config file for persistant changes #78
Comments
I have done a workaround for this. I've added an extra volume in the docker-compose.yml:
Atleast when I tested this, it worked. |
This is because in the startup process I check if the config file is present, if it is not I copy a generic one into the directory. Later in the process, I take the values you supply to the container on startup and inject those into the config overwriting whatever is present. This should only be for server name, server password, game port, query port, server slots, and server ip. Nothing else should get overwritten. Can you guys give examples of why you are manually editing the file vs just providing the container arguments? Are there settings you are wanting to modify that I don't have options for? I can add more options if that is the case. |
Some related discussion here: #79 |
@jsknnr I think one of the major reasons for this is to alter the non-host specific configs (like characters/monster/boss settings or day/night cycles, aka the "gamesettings").
Having said that, I see the example.json that you have present in the proton dir, is this config the one that we can make customizations to and have it get pulled in to the server on startup? I see it gets pulled into the container but it never gets updated to the expected filename (it keeps the "_example" in the name). |
@baine-reynolds It should get copied with the correct name:
The example is probably out of date. I added a new argument (EXTERNAL_CONFIG=1) to container start that will not do anything to the server config file. It won't copy the example and it won't update settings based on other arguments. |
I've updated the example to include the newer settings |
Oh awesome! Thanks for the clarification! I was just blind and missed it. |
I am attempting to change the config file for all the server pieces. When I change any of the values, it completely resets the config file, even knocking out the password.
The text was updated successfully, but these errors were encountered: