Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant error in validation: [components.schemas.answer.properties.id.$ref] The property $ref is required #774

Open
SOHELAHMED7 opened this issue Jan 15, 2025 · 2 comments · May be fixed by #775
Assignees

Comments

@SOHELAHMED7
Copy link

In many OpenAPI spec validation done by this library, we get redundant error

[components.schemas.answer.properties.id.$ref] The property $ref is required

This error is mentioned in #685 and cebe/php-openapi#165

@DannyvdSluijs
Copy link
Collaborator

Thanks for linking this, @SOHELAHMED7! This is a significant first step.

Could you provide more detailed reproduction steps and additional info such as the version jsonrainbow/json-schema (previously justinrainbow/json-schema) being used? In its current state, we would need to conduct all the investigation ourselves.

I see that @cebe mentioned linking to a V3 OpenAPI schema in this issue, but a quick search (https://github.com/OAI/OpenAPI-Specification/tree/main/schemas/v3.0 or OpenAPI) didn’t yield any results.

This project is maintained by a small group of contributors who are focused on keeping up with modern PHP versions, new schema drafts, and additional features like Bowtie. Unfortunately, we don’t have the bandwidth to deep dive into potential issues without a clear reproduction path.

We appreciate your help and input!

@SOHELAHMED7
Copy link
Author

Could you provide more detailed reproduction steps

that is what I am first trying to do. But at this moment I am not able to create a minimal stand-alone failing test or reproduction steps. So I don't have now.

This issue occurs when this lib is used in other project.


package name and version

"name": "justinrainbow/json-schema",
"version": "5.3.0", 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants