Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta.canonical in sample.resume.json is 404 #470

Open
etu opened this issue Oct 19, 2023 · 2 comments
Open

meta.canonical in sample.resume.json is 404 #470

etu opened this issue Oct 19, 2023 · 2 comments

Comments

@etu
Copy link

etu commented Oct 19, 2023

In the 1.0.0 release of the file sample.resume.json the value meta.canonical points to a path that is now 404.

See this file: https://github.com/jsonresume/resume-schema/blob/7095651fbbb593d2c5dc2db3095412b170d74d2e/sample.resume.json
It points to: https://raw.githubusercontent.com/jsonresume/resume-schema/master/resume.json

This should probably point to: https://raw.githubusercontent.com/jsonresume/resume-schema/master/schema.json

On master it points to: https://raw.githubusercontent.com/jsonresume/resume-schema/master/sample.resume.json which probably is wrong as well.

This came up to me in the issue here TaserudConsulting/jsonresume-nix#3 because I got bad URL's from resumed which is an issue that I've reported here: rbardini/resumed#8

However, this library would need a new release that addresses this so resumed can update and actually provide the correct path in it's sample.

@rbardini
Copy link
Contributor

$schema seems to point to the correct (versioned) URL. The file on master is the latest schema, which may not match the published one.

meta.canonical points to a valid file on master, but like $schema, I think it should point to a versioned URL. Opened #472 fixing that.

Either way, we need a new release to fix the broken resume.json reference—and the versions in sample.resume.json must be updated beforehand to match the new release version.

@thomasdavis
Copy link
Member

thomasdavis commented Jul 10, 2024

Hi guys, I've merged @rbardini changes (thank you) and I've pushed a new version of [email protected]

I've always decided to do things differently going fourth

The current working version of the schema is `v1.0.0` that is represented by the `master` branch and the files `schema.json` and `sample.resume.json`.

Such that master shall always be the most stable newest version. And develop will be used for working on new versions going fourth.

I'm also probably going to change the package name to @jsonresume/schema

edit: i did change the package name to @jsonresume/schema (well pushed a new one, old one still works but will be forever stuck at v1 schema)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants