diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 142f3a93a..c5514dafb 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -2,7 +2,7 @@ Contribution to this repository is welcome. Contribution can be either an issue report or a code or a documentation update. Also see the information in the -[main README][Zonemaster/Zonemaster README] in the main Zonemaster respository. +[main README][Zonemaster/Zonemaster README] in the main Zonemaster repository. ## Issue diff --git a/Changes b/Changes index abd1dafb4..a2d254914 100644 --- a/Changes +++ b/Changes @@ -109,7 +109,7 @@ v4.6.1 2023-01-31 (public fix version) - Updates translations (#1180, #1167) - Fixes a bug that made implementation of ADDRESS01 crash (#1181) - Fixes a bug that made implementation of NAMESERVER11 create false error - when server returned legimate EDNS OPTION-CODE (#1173, #1177) + when server returned legitimate EDNS OPTION-CODE (#1173, #1177) - Removed unneeded binary dependency from installation instruction for Ubuntu and Debian (#1176) - Fixes a bug that made implementation of ZONE01 crash when more than @@ -359,7 +359,7 @@ v3.1.2 2020-05-22 [Fixes] - Comparison in Zone10 on SOA owner name was done in case - senstive manner which created false ERRORs for some zones + sensitive manner which created false ERRORs for some zones and depending on the case of input zone name (#734, #737) @@ -376,7 +376,7 @@ v3.1.0 2020-04-30 - Allow installation of new LDNS on Debian 9 (#667) - Add more meaningful message for unsupported algorithms in DNSSEC test cases (#641, #632) - - Improved the hanling of "fuzzy" PO files (#640, #598, #600, #596) + - Improved the handling of "fuzzy" PO files (#640, #598, #600, #596) - Implementation of revised version of DNSSEC10 (#633, #618, #632) - Implementation of revised version of DNSSEC01 (#627, #616, #308) - Implementation of revised version of DELEGATION05 (#628, #617, #236) @@ -525,9 +525,9 @@ v3.0.0 2019-01-25 (pre-release version) support #462 - Various #481, #485 - Fixes - - Uppdated formatting of msgid tables #402 + - Updated formatting of msgid tables #402 - Fixed broken tests #412 - - All link references on Github now to zonemaster/zonemaster instead + - All link references on GitHub now to zonemaster/zonemaster instead of old dotse/zonemaster #406 - Updated manifest #422 - Updated travis conf to match supported perl versions (#426, #463) @@ -599,7 +599,7 @@ v2.0.0 - Updated translations (#127, #196, #216, #248, #249, #291) - Incremented VERSION of internal packages (98868cb) - Other changes - - Fixed Commonmark rendering for Github (cc7a28a) + - Fixed Commonmark rendering for GitHub (cc7a28a) - Switch msgfmt implementation to pure Perl (#223, #224) - New Unit tests infrastructure. 896 tests kept, 2 removed, will be added back later (#310) @@ -615,7 +615,7 @@ v1.1.0 2017-04-04 Public pre-release - Solved Duplicate tag in en.po (#252) - Solved Update documentation for logfilters (#221) - add Ed25519 (15) and Ed448 (16) algorithms (#290) -- Solved Not-existent name server doesn't cause a failure (#278) +- Solved Nonexistent name server doesn't cause a failure (#278) v1.0.16 2016-12-12 @@ -654,7 +654,7 @@ v1.0.14 2016-06-15 - Would be nice to add a count of name servers #453 - Partly resolved "JSON/JSON::XS usage and requirement", see issue #165 - nameserver03 test should not perform network requests, issue #168 - - Locale files are not generated nor installed #173 + - Locale files are neither generated nor installed #173 - ASN test should only look at authoritative nameservers at the child, issue #441 - Modify the "Notice" information when DNSSEC not signed, issue #193 - Implement updated test case dnssec02, issue #187 @@ -690,7 +690,7 @@ v1.0.8 2015-11-16 v1.0.7 2015-10-01 - ASN in logs are now arrays - - Make test witout IPv6 connectivity works, fixes #121 + - Make test without IPv6 connectivity works, fixes #121 - Now requires Net::Socket::IP - Fixes malformed log messages @@ -733,7 +733,7 @@ v1.0.3 2015-04-07 - Refer to overview page from Zonemaster page. - Fix missed corner case in parent-finding algorithm. - CNAME handling accidentally left outside check for packet existence. - - Clearer message when failling signature checks because GOST support is + - Clearer message when failing signature checks because GOST support is not present. v1.0.2 2015-02-24 diff --git a/MANIFEST.SKIP b/MANIFEST.SKIP index ef40388ef..9639ac3cf 100644 --- a/MANIFEST.SKIP +++ b/MANIFEST.SKIP @@ -6,7 +6,7 @@ ^\.perltidyrc$ ^\.travis\.yml$ ^util/ -^share/update-po$ # PO files are exluded from dist, which makes this script meaningless in dist +^share/update-po$ # PO files are excluded from dist, which makes this script meaningless in dist ^share/Zonemaster-Engine.pot$ ^t/po-files.t$ # PO files are excluded from dist, so we cannot test them ^Dockerfile$ @@ -71,7 +71,7 @@ ^MYMETA\. #!end included /usr/share/perl/5.20/ExtUtils/MANIFEST.SKIP -# For Github action +# For GitHub action ^\.github/ # Debian packaging diff --git a/README.md b/README.md index e52837d52..c4b43bc4d 100644 --- a/README.md +++ b/README.md @@ -50,7 +50,7 @@ For participation, contact and bug reporting, please see ## License This is free software under a 2-clause BSD license. The full text of the license can -be found in the [LICENSE](LICENSE) file included in this respository. +be found in the [LICENSE](LICENSE) file included in this repository. [CPAN site]: https://metacpan.org/pod/Zonemaster::Engine diff --git a/lib/Zonemaster/Engine.pm b/lib/Zonemaster/Engine.pm index 634ba2452..f4e572b88 100644 --- a/lib/Zonemaster/Engine.pm +++ b/lib/Zonemaster/Engine.pm @@ -250,7 +250,7 @@ This manual describes the main L module. If what you're afte =item init_engine() -Run the inititalization tasks if they have not been run already. This method is called automatically in INIT block. +Run the initialization tasks if they have not been run already. This method is called automatically in INIT block. =item test_zone($name) @@ -284,7 +284,7 @@ Returns the global L object. =item all_tags() -Returns a list of all the tags that can be logged for all avilable test modules. +Returns a list of all the tags that can be logged for all available test modules. =item all_methods() diff --git a/lib/Zonemaster/Engine/Constants.pm b/lib/Zonemaster/Engine/Constants.pm index 3e670279c..c13454868 100644 --- a/lib/Zonemaster/Engine/Constants.pm +++ b/lib/Zonemaster/Engine/Constants.pm @@ -102,7 +102,7 @@ our %EXPORT_TAGS = ( qw($DURATION_5_MINUTES_IN_SECONDS $DURATION_1_HOUR_IN_SECONDS $DURATION_4_HOURS_IN_SECONDS $DURATION_12_HOURS_IN_SECONDS $DURATION_1_DAY_IN_SECONDS $DURATION_1_WEEK_IN_SECONDS $DURATION_180_DAYS_IN_SECONDS $SERIAL_BITS $SERIAL_MAX_VARIATION) ], misc => [qw($UDP_PAYLOAD_LIMIT $UDP_EDNS_QUERY_DEFAULT $UDP_COMMON_EDNS_LIMIT $MINIMUM_NUMBER_OF_NAMESERVERS $RESOLVER_SOURCE_OS_DEFAULT $BLACKLISTING_ENABLED)] - , # everyting in %EXPORT_OK that isn't included in any of the other tags + , # everything in %EXPORT_OK that isn't included in any of the other tags addresses => [qw(@IPV4_SPECIAL_ADDRESSES @IPV6_SPECIAL_ADDRESSES)], ); diff --git a/lib/Zonemaster/Engine/Nameserver.pm b/lib/Zonemaster/Engine/Nameserver.pm index 77ee7cf96..f47150a8d 100644 --- a/lib/Zonemaster/Engine/Nameserver.pm +++ b/lib/Zonemaster/Engine/Nameserver.pm @@ -744,7 +744,7 @@ Zonemaster::Engine::Nameserver - object representing a DNS nameserver This is a very central object in the L framework. All DNS communications with the outside world pass through here, so we can do -things like synthezising and recording traffic. All the objects are +things like synthesizing and recording traffic. All the objects are also unique per name/IP pair, and creating a new one with an already existing pair will return the existing object instead of creating a new one. Queries and their responses are cached by IP address, so that @@ -767,7 +767,7 @@ A L object holding the nameserver's address. =item dns -The L object used to actually send and recieve DNS queries. +The L object used to actually send and receive DNS queries. =item cache diff --git a/lib/Zonemaster/Engine/Normalization/Error.pm b/lib/Zonemaster/Engine/Normalization/Error.pm index ba30fd4c7..e692c11c2 100644 --- a/lib/Zonemaster/Engine/Normalization/Error.pm +++ b/lib/Zonemaster/Engine/Normalization/Error.pm @@ -26,7 +26,7 @@ Zonemaster::Engine::Normalization::Error - normalization error class Readonly my %ERRORS => ( AMBIGUOUS_DOWNCASING => { - message => N__ 'Ambiguous downcaseing of character "{unicode_name}" in the domain name. Use all lower case instead.', + message => N__ 'Ambiguous downcasing of character "{unicode_name}" in the domain name. Use all lower case instead.', arguments => [ 'unicode_name' ] }, DOMAIN_NAME_TOO_LONG => { @@ -117,7 +117,7 @@ sub message { =item tag -Returns the message tag asscociated to the error. +Returns the message tag associated to the error. =cut diff --git a/lib/Zonemaster/Engine/Packet.pm b/lib/Zonemaster/Engine/Packet.pm index a03f7b066..051aa8f12 100644 --- a/lib/Zonemaster/Engine/Packet.pm +++ b/lib/Zonemaster/Engine/Packet.pm @@ -182,7 +182,7 @@ Returns true if the packet represents an existing DNS node lacking any records o =item no_such_name -Returns true if the packet represents a non-existent DNS node. +Returns true if the packet represents a nonexistent DNS node. =item is_redirect @@ -206,7 +206,7 @@ Returns true if the packet holds any RRs of the specified type for the given nam =item answerfrom -Wrapper for the underlying packet method, that replaces udnefined values with the string CunknownE>. +Wrapper for the underlying packet method, that replaces undefined values with the string CunknownE>. =item TO_JSON diff --git a/lib/Zonemaster/Engine/Profile.pm b/lib/Zonemaster/Engine/Profile.pm index 8545d8211..e1652e32d 100644 --- a/lib/Zonemaster/Engine/Profile.pm +++ b/lib/Zonemaster/Engine/Profile.pm @@ -133,7 +133,7 @@ my %profile_properties_details = ( type => q{Str}, test => sub { if ( lc($_[0]) ne q{cymru} and lc($_[0]) ne q{ripe} ) { - die "Property asn_db.style has 2 possible values : Cymru or RIPE (case insensitive)"; + die "Property asn_db.style has 2 possible values : Cymru or RIPE (case-insensitive)"; } $_[0] = lc($_[0]); }, @@ -144,7 +144,7 @@ my %profile_properties_details = ( test => sub { foreach my $db_style ( keys %{$_[0]} ) { if ( lc($db_style) ne q{cymru} and lc($db_style) ne q{ripe} ) { - die "Property asn_db.sources keys have 2 possible values : Cymru or RIPE (case insensitive)"; + die "Property asn_db.sources keys have 2 possible values : Cymru or RIPE (case-insensitive)"; } if ( not scalar @{ ${$_[0]}{$db_style} } ) { die "Property asn_db.sources.$db_style has no items"; @@ -349,7 +349,7 @@ sub _set { Data::Dumper::Dumper($value); # $value is a Scalar if ( ! $value_type or $value_type eq q{SCALAR} ) { - die "Property $property_name can not be undef" if not defined $value; + die "Property $property_name cannot be undef" if not defined $value; # Boolean if ( $profile_properties_details{$property_name}->{type} eq q{Bool} ) { diff --git a/lib/Zonemaster/Engine/Recursor.pm b/lib/Zonemaster/Engine/Recursor.pm index 1529cca9e..a3aa50f88 100644 --- a/lib/Zonemaster/Engine/Recursor.pm +++ b/lib/Zonemaster/Engine/Recursor.pm @@ -426,7 +426,7 @@ argument. =head2 add_fake_addresses($domain, $data) -Class method to create fake adresses for fake delegations for a specified domain from data provided. +Class method to create fake addresses for fake delegations for a specified domain from data provided. =head2 has_fake_addresses($domain) diff --git a/lib/Zonemaster/Engine/Test/DNSSEC.pm b/lib/Zonemaster/Engine/Test/DNSSEC.pm index 303dc8d41..bfad9f6d0 100644 --- a/lib/Zonemaster/Engine/Test/DNSSEC.pm +++ b/lib/Zonemaster/Engine/Test/DNSSEC.pm @@ -1036,19 +1036,19 @@ Readonly my %TAG_DESCRIPTIONS => ( }, DS10_NAME_NOT_COVERED_BY_NSEC => sub { __x # DNSSEC:DS10_NAME_NOT_COVERED_BY_NSEC - 'A non-existent name is not correctly covered by the NSEC records. Fetched from ' + 'A nonexistent name is not correctly covered by the NSEC records. Fetched from ' . 'the nameservers with IP addresses "{ns_ip_list}".', @_; }, DS10_NAME_NOT_COVERED_BY_NSEC3 => sub { __x # DNSSEC:DS10_NAME_NOT_COVERED_BY_NSEC3 - 'A non-existent name is not correctly covered by the NSEC3 records. Fetched from ' + 'A nonexistent name is not correctly covered by the NSEC3 records. Fetched from ' . 'the nameservers with IP addresses "{ns_ip_list}".', @_; }, DS10_NON_EXISTENT_RESPONSE_ERROR => sub { __x # DNSSEC:DS10_NON_EXISTENT_RESPONSE_ERROR - 'No response or error in response on an expected non-existent name. Fetched from ' + 'No response or error in response on an expected nonexistent name. Fetched from ' . 'the nameservers with IP addresses "{ns_ip_list}".', @_; }, @@ -3028,7 +3028,7 @@ sub dnssec10 { #---------------------------------------------------------------------- # vi. If the following criteria are met go to next name server IP: - # a. The The RCODE of response is "NoError". + # a. The RCODE of response is "NoError". # b. The answer section has an RRset with RR type "A" and either: # a. The "A" RRset has the same owner name as the query name, or # b. There are one or more record of RR type "CNAME" chaining from @@ -3043,10 +3043,10 @@ sub dnssec10 { # # Testing zones : # SHOULD NOT PASS - # - dnssec10-non-existent-domain-name-exists-01.zft-root.rd.nic.fr - # - dnssec10-non-existent-domain-name-exists-02.zft-root.rd.nic.fr + # - dnssec10-nonexistent-domain-name-exists-01.zft-root.rd.nic.fr + # - dnssec10-nonexistent-domain-name-exists-02.zft-root.rd.nic.fr # SHOULD PASS - # - dnssec10-non-existent-domain-name-exists-03.zft-root.rd.nic.fr + # - dnssec10-nonexistent-domain-name-exists-03.zft-root.rd.nic.fr #---------------------------------------------------------------------- if ( $a_p->rcode eq q{NOERROR} ) { my $step_a = 1; @@ -3100,7 +3100,7 @@ sub dnssec10 { } #---------------------------------------------------------------------- # vii. If the following criteria are met go to next name server IP: - # a. The The RCODE of response is "NoError". + # a. The RCODE of response is "NoError". # b. The answer section has one or more record of RR type "CNAME" in # a chain where first record has the owner name matching the query name. # c. The answer section has RRsig record or records in the answer section @@ -3111,7 +3111,7 @@ sub dnssec10 { # # Testing zones : # SHOULD NOT PASS - # - dnssec10-non-existent-domain-name-exists-04.zft-root.rd.nic.fr + # - dnssec10-nonexistent-domain-name-exists-04.zft-root.rd.nic.fr #---------------------------------------------------------------------- if ( $a_p->rcode eq q{NOERROR} ) { my $step_a = 1; @@ -3181,7 +3181,7 @@ sub dnssec10 { # # Testing zones : # DS10_ANSWER_VERIFY_ERROR - # - dnssec10-non-existent-domain-name-exists-05.zft-root.rd.nic.fr + # - dnssec10-nonexistent-domain-name-exists-05.zft-root.rd.nic.fr #---------------------------------------------------------------------- my @rrset; push @rrset, @a_records, @cname_records; diff --git a/lib/Zonemaster/Engine/TestMethodsV2.pm b/lib/Zonemaster/Engine/TestMethodsV2.pm index af390bdbf..c5dfb709b 100644 --- a/lib/Zonemaster/Engine/TestMethodsV2.pm +++ b/lib/Zonemaster/Engine/TestMethodsV2.pm @@ -389,7 +389,7 @@ sub get_zone_ns_names { [Internal] -This Method will obtain obtain the address records matching the In-Bailiwick name server names from the given zone. +This Method will obtain the address records matching the In-Bailiwick name server names from the given zone. Takes a Zonemaster::Engine::Zone object (C<$zone>). diff --git a/lib/Zonemaster/Engine/Translator.pm b/lib/Zonemaster/Engine/Translator.pm index d4fce3bf1..1f51cbbab 100644 --- a/lib/Zonemaster/Engine/Translator.pm +++ b/lib/Zonemaster/Engine/Translator.pm @@ -116,7 +116,7 @@ around 'BUILDARGS' => sub { # Get the program's underlying LC_MESSAGES and make sure it can be effectively # updated down the line. # -# If the underlying LC_MESSAGES is invalid, it attempts to second guess Perls +# If the underlying LC_MESSAGES is invalid, it attempts to second guess Perl's # fallback locale. # # Side effects: diff --git a/t/Test-dnssec.t b/t/Test-dnssec.t index c9d0fc498..21c1961c8 100644 --- a/t/Test-dnssec.t +++ b/t/Test-dnssec.t @@ -234,20 +234,20 @@ zone_gives_not( 'dnssec09', $zone, [qw{DS09_ALGO_NOT_SUPPORTED_BY_ZM DS09_MISSIN ########### # dnssec10 ########### -$zone = Zonemaster::Engine->zone( 'dnssec10-non-existent-domain-name-exists-01.zft-root.rd.nic.fr' ); +$zone = Zonemaster::Engine->zone( 'dnssec10-nonexistent-domain-name-exists-01.zft-root.rd.nic.fr' ); zone_gives_not( 'dnssec10', $zone, [qw{DS10_ALGO_NOT_SUPPORTED_BY_ZM DS10_ANSWER_VERIFY_ERROR DS10_HAS_NSEC DS10_HAS_NSEC3 DS10_INCONSISTENT_NSEC_NSEC3 DS10_MISSING_NSEC_NSEC3 DS10_MIXED_NSEC_NSEC3 DS10_NAME_NOT_COVERED_BY_NSEC DS10_NAME_NOT_COVERED_BY_NSEC3 DS10_NON_EXISTENT_RESPONSE_ERROR DS10_NSEC3_MISSING_SIGNATURE DS10_NSEC3_RRSIG_VERIFY_ERROR DS10_NSEC_MISSING_SIGNATURE DS10_NSEC_RRSIG_VERIFY_ERROR DS10_UNSIGNED_ANSWER}] ); -$zone = Zonemaster::Engine->zone( 'dnssec10-non-existent-domain-name-exists-02.zft-root.rd.nic.fr' ); +$zone = Zonemaster::Engine->zone( 'dnssec10-nonexistent-domain-name-exists-02.zft-root.rd.nic.fr' ); zone_gives_not( 'dnssec10', $zone, [qw{DS10_ALGO_NOT_SUPPORTED_BY_ZM DS10_ANSWER_VERIFY_ERROR DS10_HAS_NSEC DS10_HAS_NSEC3 DS10_INCONSISTENT_NSEC_NSEC3 DS10_MISSING_NSEC_NSEC3 DS10_MIXED_NSEC_NSEC3 DS10_NAME_NOT_COVERED_BY_NSEC DS10_NAME_NOT_COVERED_BY_NSEC3 DS10_NON_EXISTENT_RESPONSE_ERROR DS10_NSEC3_MISSING_SIGNATURE DS10_NSEC3_RRSIG_VERIFY_ERROR DS10_NSEC_MISSING_SIGNATURE DS10_NSEC_RRSIG_VERIFY_ERROR DS10_UNSIGNED_ANSWER}] ); -$zone = Zonemaster::Engine->zone( 'dnssec10-non-existent-domain-name-exists-03.zft-root.rd.nic.fr' ); +$zone = Zonemaster::Engine->zone( 'dnssec10-nonexistent-domain-name-exists-03.zft-root.rd.nic.fr' ); zone_gives( 'dnssec10', $zone, [qw{DS10_HAS_NSEC DS10_NAME_NOT_COVERED_BY_NSEC}] ); zone_gives_not( 'dnssec10', $zone, [qw{DS10_ALGO_NOT_SUPPORTED_BY_ZM DS10_ANSWER_VERIFY_ERROR DS10_HAS_NSEC3 DS10_INCONSISTENT_NSEC_NSEC3 DS10_MISSING_NSEC_NSEC3 DS10_MIXED_NSEC_NSEC3 DS10_NAME_NOT_COVERED_BY_NSEC3 DS10_NON_EXISTENT_RESPONSE_ERROR DS10_NSEC3_MISSING_SIGNATURE DS10_NSEC3_RRSIG_VERIFY_ERROR DS10_NSEC_MISSING_SIGNATURE DS10_NSEC_RRSIG_VERIFY_ERROR DS10_UNSIGNED_ANSWER}] ); -$zone = Zonemaster::Engine->zone( 'dnssec10-non-existent-domain-name-exists-04.zft-root.rd.nic.fr' ); +$zone = Zonemaster::Engine->zone( 'dnssec10-nonexistent-domain-name-exists-04.zft-root.rd.nic.fr' ); zone_gives_not( 'dnssec10', $zone, [qw{DS10_ALGO_NOT_SUPPORTED_BY_ZM DS10_ANSWER_VERIFY_ERROR DS10_HAS_NSEC DS10_HAS_NSEC3 DS10_INCONSISTENT_NSEC_NSEC3 DS10_MISSING_NSEC_NSEC3 DS10_MIXED_NSEC_NSEC3 DS10_NAME_NOT_COVERED_BY_NSEC DS10_NAME_NOT_COVERED_BY_NSEC3 DS10_NON_EXISTENT_RESPONSE_ERROR DS10_NSEC3_MISSING_SIGNATURE DS10_NSEC3_RRSIG_VERIFY_ERROR DS10_NSEC_MISSING_SIGNATURE DS10_NSEC_RRSIG_VERIFY_ERROR DS10_UNSIGNED_ANSWER}] ); -$zone = Zonemaster::Engine->zone( 'dnssec10-non-existent-domain-name-exists-05.zft-root.rd.nic.fr' ); +$zone = Zonemaster::Engine->zone( 'dnssec10-nonexistent-domain-name-exists-05.zft-root.rd.nic.fr' ); zone_gives( 'dnssec10', $zone, [q{DS10_ANSWER_VERIFY_ERROR}] ); zone_gives_not( 'dnssec10', $zone, [qw{DS10_ALGO_NOT_SUPPORTED_BY_ZM DS10_HAS_NSEC DS10_HAS_NSEC3 DS10_INCONSISTENT_NSEC_NSEC3 DS10_MISSING_NSEC_NSEC3 DS10_MIXED_NSEC_NSEC3 DS10_NAME_NOT_COVERED_BY_NSEC DS10_NAME_NOT_COVERED_BY_NSEC3 DS10_NON_EXISTENT_RESPONSE_ERROR DS10_NSEC3_MISSING_SIGNATURE DS10_NSEC3_RRSIG_VERIFY_ERROR DS10_NSEC_MISSING_SIGNATURE DS10_NSEC_RRSIG_VERIFY_ERROR DS10_UNSIGNED_ANSWER}] ); @@ -445,7 +445,7 @@ TODO: { # dnssec02 ok( $tag{DS02_ALGO_NOT_SUPPORTED_BY_ZM}, q{DS02_ALGO_NOT_SUPPORTED_BY_ZM} ); ok( $tag{DS02_DNSKEY_NOT_FOR_ZONE_SIGNING}, q{DS02_DNSKEY_NOT_FOR_ZONE_SIGNING} ); - # dnssec05 (can not exist in a live domain...) + # dnssec05 (cannot exist in a live domain...) ok( $tag{ALGORITHM_UNKNOWN}, q{ALGORITHM_UNKNOWN} ); # dnssec06 ok( $tag{EXTRA_PROCESSING_BROKEN}, q{EXTRA_PROCESSING_BROKEN} ); diff --git a/t/Test-nameserver.t b/t/Test-nameserver.t index d94dba0b4..4fca53a99 100644 --- a/t/Test-nameserver.t +++ b/t/Test-nameserver.t @@ -144,7 +144,7 @@ SKIP: { # available. skip 'no network', 2 if not $ENV{ZONEMASTER_RECORD}; - # AXFR results not well cached. Can not test cases where AXFR is avaibale + # AXFR results not well cached. Cannot test cases where AXFR is available # without network, even in case of ZONEMASTER_RECORD is not set. # $zone = Zonemaster::Engine->zone( 'nameserver03-axfr-available.zut-root.rd.nic.fr' ); # zone_gives( 'nameserver03', $zone, [q{AXFR_AVAILABLE}] ); diff --git a/t/nameserver.t b/t/nameserver.t index 7d84e051f..b690cfdae 100644 --- a/t/nameserver.t +++ b/t/nameserver.t @@ -48,7 +48,7 @@ ok( SKIP: { skip '/tmp not writable', 2 unless -w '/tmp'; - my $name = "/tmp/namserver_test_$$"; + my $name = "/tmp/nameserver_test_$$"; Zonemaster::Engine::Nameserver->save( $name ); my $count = keys %Zonemaster::Engine::Nameserver::object_cache; undef %Zonemaster::Engine::Nameserver::object_cache; diff --git a/t/profiles.t b/t/profiles.t index b30cedb65..e74b0cfc4 100644 --- a/t/profiles.t +++ b/t/profiles.t @@ -526,23 +526,23 @@ subtest 'set() updates values for set properties' => sub { subtest 'set() dies on attempts to unset properties' => sub { my $profile = Zonemaster::Engine::Profile->from_json( $EXAMPLE_PROFILE_1 ); - throws_ok { $profile->set( 'resolver.defaults.usevc', undef ); } qr/^.* can not be undef/, 'dies on attempt to unset resolver.defaults.usevc'; - throws_ok { $profile->set( 'resolver.defaults.recurse', undef ); } qr/^.* can not be undef/, 'dies on attempt to unset resolver.defaults.recurse'; - throws_ok { $profile->set( 'resolver.defaults.igntc', undef ); } qr/^.* can not be undef/, 'dies on attempt to unset resolver.defaults.igntc'; - throws_ok { $profile->set( 'resolver.defaults.fallback', undef ); } qr/^.* can not be undef/, 'dies on attempt to unset resolver.defaults.fallback'; - throws_ok { $profile->set( 'net.ipv4', undef ); } qr/^.* can not be undef/, 'dies on attempt to unset net.ipv4'; - throws_ok { $profile->set( 'net.ipv6', undef ); } qr/^.* can not be undef/, 'dies on attempt to unset net.ipv6'; - throws_ok { $profile->set( 'no_network', undef ); } qr/^.* can not be undef/, 'dies on attempt to unset no_network'; - throws_ok { $profile->set( 'resolver.defaults.retry', undef ); } qr/^.* can not be undef/, 'dies on attempt to unset resolver.defaults.retry'; - throws_ok { $profile->set( 'resolver.defaults.retrans', undef ); } qr/^.* can not be undef/, 'dies on attempt to unset resolver.defaults.retans'; - throws_ok { $profile->set( 'resolver.source', undef ); } qr/^.* can not be undef/, 'dies on attempt to unset resolver.source'; - throws_ok { $profile->set( 'resolver.source4', undef ); } qr/^.* can not be undef/, 'dies on attempt to unset resolver.source4'; - throws_ok { $profile->set( 'resolver.source6', undef ); } qr/^.* can not be undef/, 'dies on attempt to unset resolver.source6'; - throws_ok { $profile->set( 'asnroots', undef ); } qr/^.* can not be undef/, 'dies on attempt to unset asnroots'; - throws_ok { $profile->set( 'logfilter', undef ); } qr/^.* can not be undef/, 'dies on attempt to unset logfilter'; - throws_ok { $profile->set( 'test_levels', undef ); } qr/^.* can not be undef/, 'dies on attempt to unset test_levels'; - throws_ok { $profile->set( 'test_cases', undef ); } qr/^.* can not be undef/, 'dies on attempt to unset test_cases'; - throws_ok { $profile->set( 'cache', undef ); } qr/^.* can not be undef/, 'dies on attempt to unset cache'; + throws_ok { $profile->set( 'resolver.defaults.usevc', undef ); } qr/^.* cannot be undef/, 'dies on attempt to unset resolver.defaults.usevc'; + throws_ok { $profile->set( 'resolver.defaults.recurse', undef ); } qr/^.* cannot be undef/, 'dies on attempt to unset resolver.defaults.recurse'; + throws_ok { $profile->set( 'resolver.defaults.igntc', undef ); } qr/^.* cannot be undef/, 'dies on attempt to unset resolver.defaults.igntc'; + throws_ok { $profile->set( 'resolver.defaults.fallback', undef ); } qr/^.* cannot be undef/, 'dies on attempt to unset resolver.defaults.fallback'; + throws_ok { $profile->set( 'net.ipv4', undef ); } qr/^.* cannot be undef/, 'dies on attempt to unset net.ipv4'; + throws_ok { $profile->set( 'net.ipv6', undef ); } qr/^.* cannot be undef/, 'dies on attempt to unset net.ipv6'; + throws_ok { $profile->set( 'no_network', undef ); } qr/^.* cannot be undef/, 'dies on attempt to unset no_network'; + throws_ok { $profile->set( 'resolver.defaults.retry', undef ); } qr/^.* cannot be undef/, 'dies on attempt to unset resolver.defaults.retry'; + throws_ok { $profile->set( 'resolver.defaults.retrans', undef ); } qr/^.* cannot be undef/, 'dies on attempt to unset resolver.defaults.retans'; + throws_ok { $profile->set( 'resolver.source', undef ); } qr/^.* cannot be undef/, 'dies on attempt to unset resolver.source'; + throws_ok { $profile->set( 'resolver.source4', undef ); } qr/^.* cannot be undef/, 'dies on attempt to unset resolver.source4'; + throws_ok { $profile->set( 'resolver.source6', undef ); } qr/^.* cannot be undef/, 'dies on attempt to unset resolver.source6'; + throws_ok { $profile->set( 'asnroots', undef ); } qr/^.* cannot be undef/, 'dies on attempt to unset asnroots'; + throws_ok { $profile->set( 'logfilter', undef ); } qr/^.* cannot be undef/, 'dies on attempt to unset logfilter'; + throws_ok { $profile->set( 'test_levels', undef ); } qr/^.* cannot be undef/, 'dies on attempt to unset test_levels'; + throws_ok { $profile->set( 'test_cases', undef ); } qr/^.* cannot be undef/, 'dies on attempt to unset test_cases'; + throws_ok { $profile->set( 'cache', undef ); } qr/^.* cannot be undef/, 'dies on attempt to unset cache'; }; subtest 'set() dies if the given property name is invalid' => sub { diff --git a/util/convert_config_to_profile.pl b/util/convert_config_to_profile.pl index 459ae12f4..054b95d99 100755 --- a/util/convert_config_to_profile.pl +++ b/util/convert_config_to_profile.pl @@ -62,7 +62,7 @@ printf "(\"%s --help\" for help)\n", $scriptName; print "Directory $dest_dir mode must be changed.\n"; unless ( chmod (oct(755), $dest_dir) ) { - croak "Can not change directory mode."; + croak "Cannot change directory mode."; } } diff --git a/util/data2dig b/util/data2dig index d891fab5f..85cf125c7 100755 --- a/util/data2dig +++ b/util/data2dig @@ -64,7 +64,7 @@ for my $packet ( @packets ) { =head1 DESCRIPTION B exports saved Zonemaster::Engine cache files to human readable -format as cronologically ordered response packets in dig format. +format as chronologically ordered response packets in dig format. =head1 SUBROUTINES diff --git a/util/get_iana_address_spaces_infos.pl b/util/get_iana_address_spaces_infos.pl index 684bab7a3..7fdb19895 100755 --- a/util/get_iana_address_spaces_infos.pl +++ b/util/get_iana_address_spaces_infos.pl @@ -55,7 +55,7 @@ if ( ! -w $dest_dir ) { print "Directory $dest_dir mode must be changed.\n"; unless ( chmod (oct(755), $dest_dir) ) { - croak "Can not change directory mode."; + croak "Cannot change directory mode."; } } @@ -64,7 +64,7 @@ if ( -e $fn and ! -w $fn ) { print "File $fn mode must be changed.\n"; unless ( chmod (oct(664), $fn) ) { - croak "Can not change file mode."; + croak "Cannot change file mode."; } } } @@ -182,7 +182,7 @@ sub Usage { Although these files are part of Zonemaster distribution, they are subject to changes and it is important that Zonemaster use last versions in order to give more accurate tests results. - That script should be called on a regular ferquency basis to keep synchronization with IANA registries. + That script should be called on a regular frequency basis to keep synchronization with IANA registries. ${_bold}OPTIONS${_normal} --help