Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp repsponse 'InitializeResult' doesn't include 'documentFormattingProvider' capability #442

Open
sify21 opened this issue Jan 24, 2024 · 4 comments

Comments

@sify21
Copy link

sify21 commented Jan 24, 2024

I'm using this as a language server together with foundry and coc.nvim. Since it's not published on npm yet, I installed locally

git clone [email protected]:juanfranblanco/vscode-solidity.git
cd  vscode-solidity
npm ci
npm run prepublishOnly
npm link

Readme says formatting can be provided by forge, but 'InitializeResult' lsp response doesn't include this capability. see issue neoclide/coc.nvim#4869

@juanfranblanco
Copy link
Owner

@sify21 that is not done in the lsp it is done via the client side.

@sify21
Copy link
Author

sify21 commented Feb 15, 2024

Oh, I thought lsp was working like a proxy, directing formatting request to the actual formatting provider which is Forge or Prettier

@juanfranblanco
Copy link
Owner

In this scenario it works in the "client" side not the lsp

@juanfranblanco
Copy link
Owner

It will need to be investigated how to move it all to the lsp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants