Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying fixed elements in example #28

Open
juanparadox opened this issue Feb 6, 2017 · 3 comments
Open

Displaying fixed elements in example #28

juanparadox opened this issue Feb 6, 2017 · 3 comments
Assignees

Comments

@juanparadox
Copy link
Owner

Some elements are fixed. In this case, as I was working through the nav components, some of those components have to be fixed to the top of the page, but they don't render currently due to the way we are showing each example component.

If we show these elements as simply by what they look like and not by how they both look and behave, it is not adequate for anyone wanting to use it since they will not have a good view of the final component.

How should we handle these? or should we just code these fixed components, but resolve how to show them on the example page later?

@anater
Copy link
Collaborator

anater commented Feb 6, 2017

Hmm. Good point. I'm not sure. I wonder how Bootstrap handles this. Also wonder if it ought to be a prop of some sort 🤔

@juanparadox
Copy link
Owner Author

Well, as far as it being a prop, I don't believe it should be a prop because "Fixed" is in the name of the component. We would be creating a new component that tachyons has not defined at that point.

@juanparadox
Copy link
Owner Author

Bootstrap simply shows the fixed elements without them actually being fixed, but explains their positioning through their documentation. Should we go that route or the individual page route?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants