Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox fails when using python < 3.6 #1

Open
hpk42 opened this issue Jan 4, 2018 · 4 comments
Open

tox fails when using python < 3.6 #1

hpk42 opened this issue Jan 4, 2018 · 4 comments

Comments

@hpk42
Copy link

hpk42 commented Jan 4, 2018

when trying to run tox -e py35 or in a direct pytest run on py35 i get these errors:
https://gist.github.com/hpk42/3280fcdd13064f70606d9356a545fef7

@juga0
Copy link
Owner

juga0 commented Jan 4, 2018

Thanks for reporting this.

tox has py36 env, not py35 (/juga0/pyac/blob/master/tox.ini#L2).

Though the error doesn't come from the python version, i'm not able to reproduce it. Are you running the last version from master?, which steps you followed to run it?

@hpk42
Copy link
Author

hpk42 commented Jan 4, 2018

i am using ubuntu 16.04 as base system and do not have python3.6 there. i just went to a fresh checkout and typed "tox -e py35". It indeed seems you are using py36 features that .e.g you can pass "LocalPath" objects to os.stat(). What happens if you do "tox -e py35" on your machine?

@juga0
Copy link
Owner

juga0 commented Jan 4, 2018

tox -e py35
GLOB sdist-make: /tmp/pyac/setup.py
py35 create: /tmp/pyac/.tox/py35
ERROR: InterpreterNotFound: python3.5
__________________________ summary ___________________________
ERROR:   py35: InterpreterNotFound: python3.5

:)

You're right the bug come from the version, however if you just run tox then the error will be?

ERROR:   py36: InterpreterNotFound: python3.6

I'd prioritize to implement all functionality and only add support other versions if actually this is used. If you prefer to don't add artful to your sources.list and pin it nor have access to a vm or other machine, then i can change this.

@juga0 juga0 changed the title test run on master fails tox fails when using python < 3.6 Jan 4, 2018
@juga0
Copy link
Owner

juga0 commented Jan 18, 2018

I changed the code so it can also run with Python 3.5
It'd be great if you could test it again.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants