Errors in Ansible playbooks are not logged

[jguedez]

Errors in Ansible playbooks from contrib.ansible are not logged. This seems to be related to using check_call instead of check_output on [0].

This creates issues on projects that use this library as end users have no way of knowing what the problem actually is [1]

2021-02-18 23:20:12 WARNING install File "/var/lib/juju/agents/unit-elasticsearch-2/charm/hooks/charmhelpers/contrib/ansible/__init__.py", line 282, in execute
2021-02-18 23:20:12 WARNING install charmhelpers.contrib.ansible.apply_playbook(
2021-02-18 23:20:12 WARNING install File "/var/lib/juju/agents/unit-elasticsearch-2/charm/hooks/charmhelpers/contrib/ansible/__init__.py", line 216, in apply_playbook
2021-02-18 23:20:12 WARNING install subprocess.check_call(call, env=env)
2021-02-18 23:20:12 WARNING install File "/usr/lib/python3.8/subprocess.py", line 364, in check_call
2021-02-18 23:20:12 WARNING install raise CalledProcessError(retcode, cmd)
2021-02-18 23:20:12 WARNING install subprocess.CalledProcessError: Command '['ansible-playbook', '-c', 'local', 'playbook.yaml', '--tags', 'install']' returned non-zero exit status 2.
2021-02-18 23:20:12 ERROR juju.worker.uniter.operation runhook.go:136 hook "install" (via explicit, bespoke hook script) failed: exit status 1

Another issue has a similar problem [2]

[0] https://github.com/juju/charm-helpers/blob/master/charmhelpers/contrib/ansible/__init__.py#L216
[1] https://bugs.launchpad.net/charm-elasticsearch/+bug/1916263
[2] #607