auth_uri is deprecated from group keystone_authtoken #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option "auth_uri" from group "keystone_authtoken" is deprecated for removal. The auth_uri token is deprecated in favor of www_authenticate_uri. This commit changes the use of auth_uri to www_authenticate_uri correctly.
ajkavanagh
previously approved these changes
Nov 29, 2022
ajkavanagh
dismissed
their stale review
I didn't quite think things through.
|
So the associated review needs work (a c-h sync from this branch/PR) before it can verify the changes. |
ajkavanagh
added
Incomplete
|
@rahulsinghcanonical Just to clarify:
What I mean is, that an API service (e.g. cinder) needs to have this change synced into it (make sync); if the PR that was recently abandoned is updated then it will test this PR and thus we can move to merge the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option "auth_uri" from group "keystone_authtoken" is deprecated for removal. The auth_uri token is deprecated in favor of www_authenticate_uri. This commit changes the use of auth_uri to www_authenticate_uri correctly.
Fixes #749