Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should example code work as is? #30

Open
MrHubble opened this issue Jun 12, 2020 · 1 comment
Open

Should example code work as is? #30

MrHubble opened this issue Jun 12, 2020 · 1 comment

Comments

@MrHubble
Copy link

Thanks for creating this great resource 🙌

Is it a goal that readers should be able to copy and use the code and have a working example?

With the Single Responsibility article, I can't determine where open would be called from with the good example:

Screen Shot 2020-06-12 at 11 56 08 am

With the bad example, I can imply that there would be a button/link with a openModal action:

Screen Shot 2020-06-12 at 11 58 04 am

@julianrubisch
Copy link
Owner

I‘m currently adding some codesandbox examples
and have cleaned up a few things.

You’re very encouraged to add more examples where you think there belong more (or point out the examples to me)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants