From 73628de2cdf6f1d9aba4e633cb8ce2d7625e4d7b Mon Sep 17 00:00:00 2001 From: Ayaz Salikhov Date: Fri, 21 Feb 2025 18:58:30 +0000 Subject: [PATCH] Fail if test dir doesn't exist (#2233) --- tests/hierarchy/images_hierarchy.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tests/hierarchy/images_hierarchy.py b/tests/hierarchy/images_hierarchy.py index ee7e0e4b5a..c8cb6a47cf 100644 --- a/tests/hierarchy/images_hierarchy.py +++ b/tests/hierarchy/images_hierarchy.py @@ -9,7 +9,7 @@ # Please, take a look at the hierarchy of the images here: # https://jupyter-docker-stacks.readthedocs.io/en/latest/using/selecting.html#image-relationships -ALL_IMAGES = { +_IMAGE_PARENT = { "docker-stacks-foundation": None, "base-notebook": "docker-stacks-foundation", "minimal-notebook": "base-notebook", @@ -30,9 +30,8 @@ def get_test_dirs( if short_image_name is None: return [] - test_dirs = get_test_dirs(ALL_IMAGES[short_image_name]) - if ( - current_image_tests_dir := IMAGE_SPECIFIC_TESTS_DIR / short_image_name - ).exists(): - test_dirs.append(current_image_tests_dir) + test_dirs = get_test_dirs(_IMAGE_PARENT[short_image_name]) + current_test_dir = IMAGE_SPECIFIC_TESTS_DIR / short_image_name + assert current_test_dir.exists(), f"{current_test_dir} does not exist." + test_dirs.append(current_test_dir) return test_dirs