Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default Branch to Main #311

Open
ericvd-ucb opened this issue Jun 7, 2023 · 1 comment · May be fixed by #337
Open

Change default Branch to Main #311

ericvd-ucb opened this issue Jun 7, 2023 · 1 comment · May be fixed by #337
Labels
enhancement

Comments

@ericvd-ucb
Copy link

ericvd-ucb commented Jun 7, 2023 •
edited
Loading

Proposed change

Could we change the default branch to Main from Master?
It has been a couple years

Alternative options

Some other option where users as a default dont specify a branch

Who would use this feature?

Anyone using a github.com repo created in the past 2 years

(Optional): Suggest a solution

I tried to find where it is in the js file but I couldnt figure it out
https://github.com/jupyterhub/nbgitpuller/blob/main/docs/_static/link_gen/link.js

@balajig @sean-morris
yuvipanda added a commit to yuvipanda/nbgitpuller that referenced this issue Jan 9, 2024
@yuvipanda
Don't hardcode 'master' into the link generator
d93d84a 
Just leaving it empty now checks out HEAD, which is the default
branch.

Fixes jupyterhub#311
@yuvipanda yuvipanda linked a pull request Jan 9, 2024 that will close this issue
Open
@yuvipanda
Copy link
Contributor

@ericvd-ucb should be fixed by #337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't hardcode 'master' into the link generator yuvipanda/nbgitpuller
2 participants
@yuvipanda @ericvd-ucb