Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved diff Updated mods #73

Open
Xikaro opened this issue Dec 21, 2024 · 3 comments
Open

Improved diff Updated mods #73

Xikaro opened this issue Dec 21, 2024 · 3 comments
Labels
enhancement Enhancement of an existing feature

Comments

@Xikaro
Copy link

Xikaro commented Dec 21, 2024

Implement filtering based on a regular expression, so that only the version change is displayed, for example, discard the repeating part, such as the mod name and the version of minecraft and forge/fabric

Or just the name, almost all mods use different version semantics, but as observations show, the mod name is always in front, which can be used

before

### Updated
- Alfheim-1.4.jar                       -> Alfheim-1.5-Dev-4.jar
- BetterQuestPopup-1.12.2-1.2.1.jar     -> BetterQuestPopup-1.12.2-1.2.3.jar
- UniLib-1.0.3+1.12.2-forge.jar         -> UniLib-1.0.4+1.12.2-forge.jar

after

### Updated
- Alfheim             1.4                  -> 1.5-Dev-4
- BetterQuestPopup    1.2.1                -> 1.2.3
- UniLib              1.0.3+1.12.2-forge   -> 1.0.4+1.12.2-forge
@github-project-automation github-project-automation bot moved this to Ready🚀 in Pakku project Dec 21, 2024
@juraj-hrivnak juraj-hrivnak added the enhancement Enhancement of an existing feature label Dec 21, 2024
@juraj-hrivnak
Copy link
Owner

This might be possible to do using the FlexVer by parsing the file names, but still will not be perfect because CurseForge doesn't provide the data.

@SettingDust
Copy link
Contributor

SettingDust commented Dec 22, 2024

Extract the version info is the best choice. But not stable even with FlexVer

There is a regex I created before. https://regex101.com/r/JCgBoh/3. Will work in this situation by modify a bit. Of course, not stable without a bunch of test.

I think showing the different part first can be another workaround. Right align?
For now, the problem is the diff won't be shown correctly if the terminal too small.
图片
图片

I prefer FlexVer anyway.

@juraj-hrivnak
Copy link
Owner

juraj-hrivnak commented Dec 22, 2024

I think showing the different part first can be another workaround. Right align?
For now, the problem is the diff won't be shown correctly if the terminal too small.

This is using the mordant layout, Maybe it could be fixed using Text Wrapping, but I don't know if it will work with the layout.
But it could be formated in a completely different way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of an existing feature
Projects
Status: Ready🚀
Development

No branches or pull requests

3 participants