Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Float on top #677

Open
Stolenboot opened this issue Apr 26, 2024 · 6 comments
Open

Float on top #677

Stolenboot opened this issue Apr 26, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@Stolenboot
Copy link

This is a plea to reopen a closed issue: #350

As I commented in issue #350, making a window float on top using a third-party app is not possible on many versions of MacOS, and is difficult on other MacOS versions. Philosophically, an image viewer doing a slide show works like a video player and it seems natural to me to have this common function built in. Technically, this is also possible in QT: setWindowFlags(Qt::WindowStaysOnTopHint); (Sorry if this is wrong, I have never used the framework.)

Please reconsider, thank you!

@Stolenboot Stolenboot added the enhancement New feature or request label Apr 26, 2024
@jdpurcell
Copy link
Contributor

I just added a "Keep window on top during slideshow" option in my fork via this commit. If you'd like to try it out you can grab a build artifact (disclaimer: unofficial version; qView's original/primary author has not reviewed these changes). The setting is not enabled by default, you'd have to enable it first.

@Stolenboot
Copy link
Author

Thank you very much!!!

The build artifact quit right after launch. The MacOS secure warning (unknown developer) was not displayed so the cause is probably not the code, but the building process. I tried both the modern and legacy MacOS versions.

Anyway, I am very thankful for your work and hope the changes can be merged after reviewing.

@jdpurcell
Copy link
Contributor

That's strange, which version of macOS are you running, and on Intel or Apple silicon?

@Stolenboot
Copy link
Author

I am running MacOS 11.6 on an Intel i9 Macbook Pro.
qView 6.1 from interversehq.com works fine, FYI.

@jdpurcell
Copy link
Contributor

I was able to reproduce the crash inside a macOS VM, and I believe it's due to a problem with the specific Xcode SDK version used during compilation. The fixed build is available here if you'd like to try it. The regular macOS build supports macOS 11+ by the way; the legacy version is only needed for macOS 10.13-10.15.

@Stolenboot
Copy link
Author

Wonderful! It works. I really appreciate your work and help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants