- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Mise as Python provider #246
Comments
Hi Jannik! Many thanks for your proposal to add Mise support to VirtualFish, as well as for your patience. Just this morning I finally found time to install Mise and experiment with it, and so far I am enjoying the experience. I completely agree that we should add direct support for Mise, and your initial implementation looks like a good start. I think the next step should be to retrieve the target Python interpreter version numbers from Mise’s global configuration file at [tools]
node = "22"
python = ["3.13", "3.12", "3.11", "3.10", "3.9"] … we should add a stanza that parses that file and extracts the target Python version numbers. This is somewhat complicated by the fact that Mise supports specifying both "3.13" and "3.13.1", whereas the current Perhaps the best solution is to create several new VirtualFish internal functions. For example:
With that information at hand, we can then compare the virtual environment’s Python interpreter version number (e.g., 3.12.7) to the latest version number (e.g., 3.12.8) and then take the appropriate action: display in a different color, upgrade to the latest version, et cetera. This probably sounds a lot more complicated than I expect it will actually be to implement. In any case, is this something you would still be willing to assist with? Your help would be greatly appreciated! 😊 |
Feature Request
Hi @justinmayer, first of all, thanks for your great plugin!
I have been using virtualfish with asdf for quite a while, but recently replaced that with mise.
mise is more-or-less a drop-in replacement for asdf, but unfortunately just aliasing it does not seem to work as
mise plugin list
does not output Python as a plugin, as that one is "built-in":Trying to add the Python feature does not work, as it is built-in already:
As virtualfish checks for Python being in the output of
asdf plugin list
, this does not work:Are you interested in supporting mise with virtualfish?
I currently see three possibilities to allow using virtualfish with mise:
alias asdf="mise"
and change the behavior of requiring Python to be installed as a plugin (untested), ormise|asdf plugin list
to also include Python (untested)I guess all approaches have its pros and cons that I would be happy to discuss further if you are interested.
I have already implemented the first approach as jnk22/virtualfish at feat-support-mise.
This probably lacks the extended coloring support for the command
vf ls --details
, and potentially others that I am currently not aware of.Also, direct support for mise should be extended with mise-specific configuration files such as
~/.mise.toml
.Either way, I would be happy to implement missing features if you want to support mise in the future.
The text was updated successfully, but these errors were encountered: