Feat / add support for using a custom Chromecast receiver #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristiaanScheermeijer
requested review from
langemike,
dbudzins,
AntonLantukh and
royschut
|
Visit the preview URL for this PR (updated for commit 2989e0e): https://ottwebapp--pr672-fix-custom-chromecas-s7rk9jmd.web.app (expires Sat, 29 Mar 2025 15:17:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c198f8a3a199ba8747819f7f1e45cf602b777529 |
royschut
approved these changes
Feb 27, 2025
langemike
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When DRM is enabled for a JWP property, Chromecast is disabled by default because this isn't support when using the default receiver. This change makes it possible to change the Chromecast receiver application used by JWPlayer.
It is possible to change the receiver id by using an environment variable:
Or by passing it before the start/build script: