From 021e4fe7a47162198d0036845994ec51e8028429 Mon Sep 17 00:00:00 2001 From: Max Gautier Date: Wed, 22 May 2024 10:31:18 +0200 Subject: [PATCH] Convert check_typo to pre-commit + use maintained version client9/misspell is unmaintained, and has been forked by the golangci team, see https://github.com/client9/misspell/issues/197#issuecomment-1596318684. They haven't yet added a pre-commit config, so use my fork with the pre-commit hook config until the pull request is merged. --- .pre-commit-config.yaml | 7 +++++++ tests/scripts/check_typo.sh | 12 ------------ 2 files changed, 7 insertions(+), 12 deletions(-) delete mode 100755 tests/scripts/check_typo.sh diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index e4116c1fae0..cbafa4bb30c 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -45,6 +45,13 @@ repos: - jmespath==1.0.1 - netaddr==1.2.1 + - repo: https://github.com/VannTen/misspell + # Waiting on https://github.com/golangci/misspell/pull/19 to get merged + rev: 8592a4e + hooks: + - id: misspell + exclude: "OWNERS_ALIASES$" + - repo: local hooks: - id: ansible-syntax-check diff --git a/tests/scripts/check_typo.sh b/tests/scripts/check_typo.sh deleted file mode 100755 index 522d4b2d60c..00000000000 --- a/tests/scripts/check_typo.sh +++ /dev/null @@ -1,12 +0,0 @@ -#!/bin/bash - -# cd to the root directory of kubespray -cd $(dirname $0)/../../ - -rm ./misspell* - -set -e -wget https://github.com/client9/misspell/releases/download/v0.3.4/misspell_0.3.4_linux_64bit.tar.gz -tar -zxvf ./misspell_0.3.4_linux_64bit.tar.gz -chmod 755 ./misspell -git ls-files | grep -v OWNERS_ALIASES | xargs ./misspell -error