From 4dd469207c618f02761d3ead34bb0ec74d72013e Mon Sep 17 00:00:00 2001
From: alonSadan <asadan@redhat.com>
Date: Mon, 8 Jul 2019 18:25:23 +0300
Subject: [PATCH] add test for mac address release-FAILS

- add test that check if kubemacpool releases the mac address
  after aplying a failed yaml

*curretly the test is pending until the issue is fixed
---
 tests/virtual_machines_test.go | 57 ++++++++++++++++++++++++++++++++++
 1 file changed, 57 insertions(+)

diff --git a/tests/virtual_machines_test.go b/tests/virtual_machines_test.go
index 6b21decca..476ce41ef 100644
--- a/tests/virtual_machines_test.go
+++ b/tests/virtual_machines_test.go
@@ -364,6 +364,63 @@ var _ = Describe("Virtual Machines", func() {
 				}
 			})
 		})
+		//TODO:  remove the the pending annotation -"P"- from "PContext" when issue #44 is fixed :
+		//https://github.com/K8sNetworkPlumbingWG/kubemacpool/issues/44
+		PContext("When we re-apply a failed VM yaml", func() {
+			It("should allow to assign to the VM the same MAC addresses, name as requested before and do not return an error", func() {
+				err := setRange(rangeStart, rangeEnd)
+				Expect(err).ToNot(HaveOccurred())
+
+				vm1 := CreateVmObject(TestNamespace, false,
+					[]kubevirtv1.Interface{newInterface("br1", "02:00:ff:ff:ff:ff")},
+					[]kubevirtv1.Network{newNetwork("br1"), newNetwork("br2")})
+
+				baseVM := vm1.DeepCopy()
+
+				Eventually(func() bool {
+					err := testClient.VirtClient.Create(context.TODO(), vm1)
+					if err != nil && strings.Contains(err.Error(), "every network must be mapped to an interface") {
+						return true
+					}
+					return false
+
+				}, 40*time.Second, 5*time.Second).Should(BeTrue(), "failed to apply the new vm object")
+
+				baseVM.Spec.Template.Spec.Domain.Devices.Interfaces = append(baseVM.Spec.Template.Spec.Domain.Devices.Interfaces, newInterface("br2", ""))
+
+				Eventually(func() error {
+					return testClient.VirtClient.Create(context.TODO(), baseVM)
+
+				}, 50*time.Second, 5*time.Second).Should(Not(HaveOccurred()), "failed to apply the new vm object error")
+			})
+			It("should allow to assign to the VM the same MAC addresses, different name as requested before and do not return an error", func() {
+				err := setRange(rangeStart, rangeEnd)
+				Expect(err).ToNot(HaveOccurred())
+
+				vm1 := CreateVmObject(TestNamespace, false,
+					[]kubevirtv1.Interface{newInterface("br1", "02:00:ff:ff:ff:ff")},
+					[]kubevirtv1.Network{newNetwork("br1"), newNetwork("br2")})
+
+				baseVM := vm1.DeepCopy()
+				baseVM.Name = "new-vm"
+
+				Eventually(func() bool {
+					err := testClient.VirtClient.Create(context.TODO(), vm1)
+					if err != nil && strings.Contains(err.Error(), "every network must be mapped to an interface") {
+						return true
+					}
+					return false
+
+				}, 40*time.Second, 5*time.Second).Should(BeTrue(), "failed to apply the new vm object")
+
+				baseVM.Spec.Template.Spec.Domain.Devices.Interfaces = append(baseVM.Spec.Template.Spec.Domain.Devices.Interfaces, newInterface("br2", ""))
+
+				Eventually(func() error {
+					return testClient.VirtClient.Create(context.TODO(), baseVM)
+
+				}, 50*time.Second, 5*time.Second).Should(Not(HaveOccurred()), "failed to apply the new vm object error")
+			})
+		})
 	})
 })