ovs: add internal interface #830
Conversation
|
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
|
@ykulazhenkov PTAL |
Pull Request Test Coverage Report for Build 12734238129Details
💛 - Coveralls |
When creating a bridge with ovs-vsctl, an internal interface is added by default. The same behavior is added in this commit ovs-vsctl code ref: https://github.com/openvswitch/ovs/blob/main/utilities/ovs-vsctl.c#L1597 Signed-off-by: Fred Rolland <[email protected]>
rollandf
force-pushed
the
ovs-internal
branch
from
053fc75 to
9e2390f
Compare
There was a problem hiding this comment.
overall LGTM.
im OK with not having api change for it and let that be the default.
later on we can change if the use-case rises (e.g need to enable/disable creation of internal port or adding some external ids to it)
@rollandf what would happen to existing bridges created that dont have internal port set ? will they be reconciled ? i think no with current logic.
do we want them to be reconciled ?
| ovs := dbContent.OpenVSwitch[0] | ||
| br := dbContent.Bridge[0] | ||
| port := dbContent.Port[0] | ||
| iface := dbContent.Interface[0] | ||
| var internalPort, port *PortEntry |
There was a problem hiding this comment.
nit: i would create a port and interface map keyed by name.
that way if we have more later, there would be no need to do additional if conditions as below.
I think it is ok not to reconcile internal ports for now. If we will add such reconciliation, then all existing bridges will need to be reconfigured, meaning all nodes will be drained without any chance to opt out reconfiguration. |
When creating a bridge with ovs-vsctl, an internal interface is added by default.
The same behavior is added in this commit
ovs-vsctl code ref:
https://github.com/openvswitch/ovs/blob/main/utilities/ovs-vsctl.c#L1597