Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer resumes on uiMode change #97

Open
nicolarevelant opened this issue Sep 25, 2024 · 0 comments
Open

Timer resumes on uiMode change #97

nicolarevelant opened this issue Sep 25, 2024 · 0 comments

Comments

@nicolarevelant
Copy link

Problem: when I perform this sequence of events the timer resumes:

  1. Switch to light mode
  2. Start a match
  3. Touch reset button (timer pauses)
  4. Switch to dark mode

Note: from dark to light theme this failure does not occur

Possible solution:

  • app/src/main/java/com/kaajjo/libresudoku/ui/game/GameScreen.kt
  • app/src/main/java/com/kaajjo/libresudoku/ui/game/GameViewModel.kt
  • you have to distinguish between:
    • user pauses the game
    • onResume lifecycle event pauses the game
  • only in the latter case you have to start the timer

Screenshots:

Version:

1.5.0 (7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant