Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.4.0 included breaking changes #10

Open
blainekasten opened this issue Aug 12, 2016 · 0 comments
Open

1.4.0 included breaking changes #10

blainekasten opened this issue Aug 12, 2016 · 0 comments

Comments

@blainekasten
Copy link

blainekasten commented Aug 12, 2016

The following code worked in 1.3.2, but now breaks in 1.4.0 in Safari only.

import { Lokka } from 'lokka';
import { Transport } from 'lokka-transport-http';
import { markStateAsStale } from './State';

const client = new Lokka({
  transport: new Transport('/graphql-endpoint'),
});

client.query(validGraphqlQuery);

The fix for this was to make the transport endpoint be an absolute path. So I changed it to this:

const client = new Lokka({
  transport: new Transport(`${location.origin}/graphql-endpoint`),
});

This breaking change was unexpected in a minor bump. I would suggest possibly deprecating that version and bumping a to 2.0.0, or adding some sort of instructions around the changelog for 1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant