Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra: Move main-tagged images to a separate package #785

Open
Haarolean opened this issue Jan 15, 2025 · 4 comments
Open

Infra: Move main-tagged images to a separate package #785

Haarolean opened this issue Jan 15, 2025 · 4 comments
Labels
good first issue Up for grabs scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature

Comments

@Haarolean
Copy link
Member

Haarolean commented Jan 15, 2025

To reduce clutter in packages:

  • release images must be kept as is, snapshots (pushes to main) should be published in a separate package (ECR and GHCR, but not docker hub), like kafbat/kafka-ui-rc (rc for release candidate, naming discussable)
  • RC images should be named as a short commit sha rather than a long one as they are at the moment
  • after implementing the issue, let's cleanup old RC builds from the main package
@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/infra CI, CD, dev. env, etc. labels Jan 15, 2025
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jan 15, 2025
@Haarolean
Copy link
Member Author

#601 related, kinda

@yeikel
Copy link
Collaborator

yeikel commented Jan 16, 2025

Do not publish sha-style images on every commit, so there will be only main (recreated every push) and release tags

I do not believe this is desirable. In fact, it is a good idea to do what we are doing right now because it is easy to downgrade in case of regressions. One idea to make it even easier is to create a tag using the git commit id to make it even easier to discover.

What we can do close to what you are looking to do is to create a tag main or latest that will be updated with every main push

@Haarolean Haarolean moved this to Active in Housekeeping Jan 22, 2025
@Haarolean
Copy link
Member Author

Do not publish sha-style images on every commit, so there will be only main (recreated every push) and release tags

I do not believe this is desirable. In fact, it is a good idea to do what we are doing right now because it is easy to downgrade in case of regressions. One idea to make it even easier is to create a tag using the git commit id to make it even easier to discover.

What we can do close to what you are looking to do is to create a tag main or latest that will be updated with every main push

I understand the concern and I find these intermediate images useful as well. We've discussed this and decided to move snapshot images to a separate package (on both ghcr and ecr, but not docker hub). I'll update the description shortly.

@Haarolean Haarolean changed the title Infra: Get rid of the sha-tagged image releases Infra: Move main-tagged images to a separate package Jan 23, 2025
@Haarolean
Copy link
Member Author

This is good for grabs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Up for grabs scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
Status: Todo
Development

No branches or pull requests

2 participants