We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I am too busy with other work so I am leaving this work item. I am implementing ProcessXor in Construct and found that this code
if PY2: return bytes(bytearray(v ^ key for v in bytearray(data))) else: return bytes(v ^ key for v in data)
could easily be
return bytes(v ^ key for v in data)
because bytes([1,2,3]) works on Python 2 as well.
The text was updated successfully, but these errors were encountered:
@dgladkov did some benchmarks previously: kaitai-io/kaitai_struct_python_runtime#8 and claimed that it was the optimal solution.
Sorry, something went wrong.
Okay, then I will withdraw this and focus on more important work.
No branches or pull requests
I am too busy with other work so I am leaving this work item. I am implementing ProcessXor in Construct and found that this code
could easily be
because bytes([1,2,3]) works on Python 2 as well.
The text was updated successfully, but these errors were encountered: