Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Enhance highlighting of nested quotes in long strings. #1403

Closed
Peefy opened this issue Jun 6, 2024 · 8 comments
Closed

[Enhancement] Enhance highlighting of nested quotes in long strings. #1403

Peefy opened this issue Jun 6, 2024 · 8 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed lsp

Comments

@Peefy
Copy link
Contributor

Peefy commented Jun 6, 2024

For the following code, the chars in the long string should have consistent highlight.

aaa = """
"a" 'a' "a"
"""
bbb = """ "a" """
ccc = ''' "a" 'a' '''

image

@Peefy Peefy added enhancement New feature or request lsp labels Jun 6, 2024
@Peefy Peefy added this to the v0.9.0 Release milestone Jun 6, 2024
@Peefy Peefy assigned He1pa and unassigned He1pa Jun 6, 2024
@Peefy Peefy added help wanted Extra attention is needed good first issue Good for newcomers labels Jun 6, 2024
@cy00r
Copy link

cy00r commented Jun 7, 2024

Hey, can I work on this issue?

@cy00r
Copy link

cy00r commented Jun 12, 2024

@Peefy
Hey, can you please highlight/ping the code section where I have to make changes?

@He1pa
Copy link
Contributor

He1pa commented Jun 13, 2024

@Peefy Hey, can you please highlight/ping the code section where I have to make changes?

@cy00r
sema/core/symbol, consider use a new symbol kind to represent long string,
sema/namer/node.rs and sema/advanced_resolver/node.rs to update symbol
you can ref other kind of symbol

@Gmin2
Copy link
Contributor

Gmin2 commented Jun 17, 2024

@cy00r are yu still working on it ?

@cy00r
Copy link

cy00r commented Jun 17, 2024

@Gmin2 Yes I'm.

@cy00r cy00r removed their assignment Jun 18, 2024
@cy00r
Copy link

cy00r commented Jun 18, 2024

Hey, @Gmin2 you can work on this.

@Gmin2 Gmin2 removed their assignment Jun 22, 2024
@Gmin2
Copy link
Contributor

Gmin2 commented Jun 23, 2024

Hey @Peefy, am really sorry at the moment i am out of my hometown for 2-3 week, thats why have removed my assignment so that other contributor can give it a try

@Peefy
Copy link
Contributor Author

Peefy commented Jun 25, 2024

Closed by kcl-lang/vscode-kcl#52

@Peefy Peefy closed this as completed Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed lsp
Projects
None yet
Development

No branches or pull requests

4 participants